Skip to content

Commit 997f156

Browse files
authored
Use ci_vllm_version when recording vLLM commit (#1689)
### What this PR does / why we need it? Use ci_vllm_version when recording vllm commit Followup on #1623 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Test mannually. $ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"' v0.9.2 - Test on my local repo: Yikun#35 - vLLM version: v0.9.1 - vLLM main: vllm-project/vllm@49e8c7e Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
1 parent 89c1a0f commit 997f156

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

.github/format_pr_body.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515
# This file is a part of the vllm-ascend project.
16-
#
16+
# Adapted from vllm/.github/scripts/cleanup_pr_body.sh
1717

1818
#!/bin/bash
1919

@@ -34,11 +34,15 @@ NEW=/tmp/new_pr_body.txt
3434
gh pr view --json body --template "{{.body}}" "${PR_NUMBER}" > "${OLD}"
3535
cp "${OLD}" "${NEW}"
3636

37-
# Remove "FIX #xxxx (*link existing issues this PR will resolve*)"
37+
# Remove notes in pr description and add vLLM version and commit
3838
sed -i '/<!--/,/-->/d' "${NEW}"
3939
sed -i '/- vLLM .*$/d' "${NEW}"
40-
echo "- vLLM version: $VLLM_VERSION" >> "${NEW}"
41-
echo "- vLLM main: $VLLM_COMMIT" >> "${NEW}"
40+
{
41+
echo ""
42+
echo "- vLLM version: $VLLM_VERSION"
43+
echo "- vLLM main: $VLLM_COMMIT"
44+
echo ""
45+
} >> "${NEW}"
4246

4347
# Run this only if ${NEW} is different than ${OLD}
4448
if ! cmp -s "${OLD}" "${NEW}"; then

.github/workflows/format_pr_body.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353

5454
- name: Get vLLM release version
5555
run: |
56-
VLLM_VERSION=$(python3 docs/source/conf.py | jq .vllm_version | tr -d '"')
56+
VLLM_VERSION=$(python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"')
5757
echo "VLLM_VERSION=$VLLM_VERSION" >> $GITHUB_ENV
5858
5959
- name: Update PR description

docs/source/conf.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@
7676
'pip_vllm_version': "0.9.1",
7777
# CANN image tag
7878
'cann_image_tag': "8.1.rc1-910b-ubuntu22.04-py3.10",
79+
# vllm version in ci
80+
'ci_vllm_version': 'v0.9.2',
7981
}
8082

8183
# Add any paths that contain templates here, relative to this directory.

0 commit comments

Comments
 (0)