Skip to content

Commit 96d6fa7

Browse files
authored
[Docker] Fix openEuler image suffix (#586)
### What this PR does / why we need it? There was a bug when we release v0.8.4rc1 (openEuler image tag was wrong set to 0.8.4rc1), according doc of docker-meta-action, it should be append suffix: ``` tags: | type=pep440,enable=true,priority=900,prefix=,suffix=,pattern=,value= ``` This patch just fix openEuler image suffix to make pep440 tag rule work. This patch also remove the cache step because the cache step bring more than 10mins export, but reduce less time in next trigger. ### Does this PR introduce _any_ user-facing change? Yes, docker image tag set to right ### How was this patch tested? I test with in my fork repo by setting default branch: - release a tag: v0.7.88rc1 (pep440 tag) - The log show `--label org.opencontainers.image.version=v0.7.88rc1-openeuler` is right rule https://github.com/Yikun/vllm-ascend/actions/runs/14560411481/job/40842950165#step:9:205 Related: #489 Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
1 parent 12cae04 commit 96d6fa7

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.github/workflows/image_openeuler.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
tags: |
6363
type=ref,event=branch,suffix=-openeuler
6464
type=ref,event=pr,suffix=-openeuler
65-
type=pep440,pattern={{raw}}-openeuler
65+
type=pep440,pattern={{raw}},suffix=-openeuler
6666
6767
- name: Free up disk space
6868
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
@@ -88,8 +88,6 @@ jobs:
8888
uses: docker/build-push-action@v6
8989
with:
9090
platforms: linux/amd64,linux/arm64
91-
cache-from: type=gha
92-
cache-to: type=gha,mode=max
9391
# only trigger when tag, branch/main push
9492
push: ${{ github.event_name == 'push' && github.repository_owner == 'vllm-project' }}
9593
labels: ${{ steps.meta.outputs.labels }}

.github/workflows/image_ubuntu.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ jobs:
8888
uses: docker/build-push-action@v6
8989
with:
9090
platforms: linux/amd64,linux/arm64
91-
cache-from: type=gha
92-
cache-to: type=gha,mode=max
9391
# only trigger when tag, branch/main push
9492
push: ${{ github.event_name == 'push' && github.repository_owner == 'vllm-project' }}
9593
labels: ${{ steps.meta.outputs.labels }}

0 commit comments

Comments
 (0)