Skip to content

Commit 966557a

Browse files
authored
[Build] Speedup image build (#1216)
### What this PR does / why we need it? 1. Rename workflow name to show OS info 2. Speedup image build: - PR: only arm64 build on openEuler arm64, only amd64 build on Ubuntu amd64 - Push/Tag: still keep origin logic use qemu on amd64 This PR actually drop the e2e image build per PR but I think it's fine consider it's stable enough, if we still meet some problem we can revert this PR 43-44mins ---> about 8-10 mins ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
1 parent 4ce860a commit 966557a

File tree

2 files changed

+22
-8
lines changed

2 files changed

+22
-8
lines changed

.github/workflows/image_openeuler.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'image'
1+
name: 'image / openEuler'
22
# This is a docker build check and publish job:
33
# 1. PR Triggered docker image build check
44
# - is for image build check
@@ -33,9 +33,13 @@ on:
3333

3434
jobs:
3535
build:
36-
name: vllm-ascend openEuler image
37-
runs-on: ubuntu-latest
38-
36+
name: vllm-ascend image build
37+
runs-on: >-
38+
${{
39+
github.event_name == 'push' && github.repository_owner == 'vllm-project' &&
40+
'ubuntu-latest' ||
41+
'ubuntu-24.04-arm'
42+
}}
3943
steps:
4044
- uses: actions/checkout@v4
4145

@@ -87,7 +91,12 @@ jobs:
8791
- name: Build and push
8892
uses: docker/build-push-action@v6
8993
with:
90-
platforms: linux/amd64,linux/arm64
94+
platforms: >-
95+
${{
96+
github.event_name == 'push' && github.repository_owner == 'vllm-project' &&
97+
'linux/amd64,linux/arm64' ||
98+
'linux/arm64'
99+
}}
91100
# use the current repo path as the build context, ensure .git is contained
92101
context: .
93102
# only trigger when tag, branch/main push

.github/workflows/image_ubuntu.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'image'
1+
name: 'image / Ubuntu'
22
# This is a docker build check and publish job:
33
# 1. PR Triggered docker image build check
44
# - is for image build check
@@ -33,7 +33,7 @@ on:
3333
jobs:
3434

3535
build:
36-
name: vllm-ascend Ubuntu image
36+
name: vllm-ascend image build
3737
runs-on: ubuntu-latest
3838

3939
steps:
@@ -87,7 +87,12 @@ jobs:
8787
- name: Build and push
8888
uses: docker/build-push-action@v6
8989
with:
90-
platforms: linux/amd64,linux/arm64
90+
platforms: >-
91+
${{
92+
github.event_name == 'push' && github.repository_owner == 'vllm-project' &&
93+
'linux/amd64,linux/arm64' ||
94+
'linux/amd64'
95+
}}
9196
# use the current repo path as the build context, ensure .git is contained
9297
context: .
9398
# only trigger when tag, branch/main push

0 commit comments

Comments
 (0)