Skip to content

Commit 8ecd714

Browse files
committed
add trap
Signed-off-by: wangli <wangli858794774@gmail.com>
1 parent c922df1 commit 8ecd714

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

benchmarks/scripts/run-performance-benchmarks.sh

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,15 @@ run_serving_tests() {
187187

188188
local serving_test_file
189189
serving_test_file=$1
190+
cleanup() {
191+
if [[ -n "$server_pid" ]]; then
192+
echo "Cleaning up server process $server_pid..."
193+
kill -9 "$server_pid" 2>/dev/null || true
194+
fi
195+
kill_npu_processes
196+
}
197+
198+
trap cleanup EXIT INT TERM
190199

191200
# Iterate over serving tests
192201
jq -c '.[]' "$serving_test_file" | while read -r params; do
@@ -267,11 +276,9 @@ run_serving_tests() {
267276
kill -9 $server_pid
268277
kill_npu_processes
269278
done
279+
trap - EXIT INT TERM
270280
}
271281

272-
cleanup() {
273-
rm -rf ./vllm_benchmarks
274-
}
275282

276283
cleanup_on_error() {
277284
echo "An error occurred. Cleaning up results folder..."

0 commit comments

Comments
 (0)