Skip to content

Commit 996de81

Browse files
authored
Add pre-commit checks to quality workflows (#25)
## Summary Enhances our CI/CD pipeline by introducing pre-commit checks to the quality workflows. This ensures pre-check standards and requirements are enforced even if developers do not install pre-commit locally and won't break for others. ## Details - Added a new job to the `.github/workflows/quality.yml` file that runs pre-commit checks. - This job runs on `ubuntu-latest` and is configured to set up Python 3.8, install pre-commit, and run the pre-commit checks on all files. - Ensures that code quality checks must pass before merging, improving code consistency and reducing errors. ## Test Plan - Automated Testing: Verifying with this diff that the new github actions will pass
1 parent 331273c commit 996de81

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

.github/workflows/quality.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,16 @@ jobs:
4444
run: pip install tox
4545
- name: Run type checks
4646
run: tox -e types
47+
48+
precommit-check:
49+
runs-on: ubuntu-latest
50+
steps:
51+
- uses: actions/checkout@v4
52+
- name: Set up Python
53+
uses: actions/setup-python@v5
54+
with:
55+
python-version: "3.8"
56+
- name: Install pre-commit
57+
run: pip install pre-commit
58+
- name: Run pre-commit checks
59+
run: pre-commit run --all-files

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ repos:
2121
loguru,
2222
numpy,
2323
pydantic,
24+
pydantic_settings,
2425
pyyaml,
2526
openai,
2627
requests,

0 commit comments

Comments
 (0)