Skip to content

Commit 8a4e408

Browse files
authored
add missing ref, update to v4 (#224)
Small issue in ui-unit-test job is causing failures across all PRs since we use pull_request_target instead of pull_request for the trigger in development.yml which means that actions run against the workflow in main instead of the workflow files that might have been updated in the PR. The last UI PR was merged and brought in this buggy ui-unit-test job. I also updated the checkout action to v4 since the other non ui jobs are using v4 instead of v3 Ended up updating package-lock as well since I was getting more failures than expected, thought maybe that was the issue. Regardless, this PR passes the checks when I temporarily update the trigger from pull_request_target to pull_request
1 parent 227f170 commit 8a4e408

File tree

2 files changed

+2286
-777
lines changed

2 files changed

+2286
-777
lines changed

.github/workflows/development.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
runs-on: ubuntu-latest
3030
steps:
3131
- name: Check out code
32-
uses: actions/checkout@v3
32+
uses: actions/checkout@v4
3333
with:
3434
ref: "${{ github.event.pull_request.merge_commit_sha }}"
3535

@@ -63,7 +63,7 @@ jobs:
6363
runs-on: ubuntu-latest
6464
steps:
6565
- name: Check out code
66-
uses: actions/checkout@v3
66+
uses: actions/checkout@v4
6767
with:
6868
ref: "${{ github.event.pull_request.merge_commit_sha }}"
6969

@@ -97,7 +97,7 @@ jobs:
9797
runs-on: ubuntu-latest
9898
steps:
9999
- name: Check out code
100-
uses: actions/checkout@v3
100+
uses: actions/checkout@v4
101101
with:
102102
ref: "${{ github.event.pull_request.merge_commit_sha }}"
103103

@@ -131,7 +131,9 @@ jobs:
131131
runs-on: ubuntu-latest
132132
steps:
133133
- name: Check out code
134-
uses: actions/checkout@v3
134+
uses: actions/checkout@v4
135+
with:
136+
ref: "${{ github.event.pull_request.merge_commit_sha }}"
135137

136138
- name: Install dependencies
137139
run: npm ci
@@ -163,7 +165,7 @@ jobs:
163165
runs-on: ubuntu-latest
164166
steps:
165167
- name: Check out code
166-
uses: actions/checkout@v3
168+
uses: actions/checkout@v4
167169
with:
168170
ref: "${{ github.event.pull_request.merge_commit_sha }}"
169171

0 commit comments

Comments
 (0)