Skip to content

Commit 3946709

Browse files
committed
quality fixes
1 parent 24e6527 commit 3946709

File tree

5 files changed

+23
-23
lines changed

5 files changed

+23
-23
lines changed

src/guidellm/backend/openai.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
import base64
2+
import io
13
from typing import AsyncGenerator, Dict, List, Optional
2-
import io, base64
34

45
from loguru import logger
56
from openai import AsyncOpenAI, OpenAI
@@ -182,7 +183,7 @@ def _build_messages(self, request: TextGenerationRequest) -> Dict:
182183
image_url = {"url": f"data:image/{im_format.lower()};base64,{im_b64}"}
183184
content.append({"type": "image_url", "image_url": image_url})
184185

185-
content.append({"type": "text", "text": request.prompt})
186+
content.append({"type": "text", "text": request.prompt})
186187
messages = [{"role": "user", "content": content}]
187-
188+
188189
return messages

src/guidellm/core/request.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import uuid
2-
from typing import Any, Dict, Optional, List
2+
from typing import Any, Dict, List, Optional
33

44
from pydantic import Field
55

src/guidellm/request/emulated.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from guidellm.config import settings
1212
from guidellm.core.request import TextGenerationRequest
1313
from guidellm.request.base import GenerationMode, RequestGenerator
14-
from guidellm.utils import clean_text, filter_text, load_text, split_text, load_images
14+
from guidellm.utils import clean_text, filter_text, load_images, load_text, split_text
1515

1616
__all__ = ["EmulatedConfig", "EmulatedRequestGenerator", "EndlessTokens"]
1717

@@ -402,9 +402,9 @@ def sample_prompt(self, tokens: int) -> str:
402402
right = mid
403403

404404
return self._tokens.create_text(start_line_index, left)
405-
406-
405+
406+
407407
def sample_images(self):
408408
image_indices = self._rng.choice(len(self._images), size=self._config.images, replace=False)
409409

410-
return [self._images[i] for i in image_indices]
410+
return [self._images[i] for i in image_indices]

src/guidellm/utils/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from .images import ImageDescriptor, load_images
12
from .injector import create_report, inject_data
23
from .progress import BenchmarkReportProgress
34
from .text import (
@@ -12,7 +13,6 @@
1213
split_lines_by_punctuation,
1314
split_text,
1415
)
15-
from .images import load_images, ImageDescriptor
1616
from .transformers import (
1717
load_transformers_dataset,
1818
resolve_transformers_dataset,

src/guidellm/utils/images.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
from PIL import Image
2-
from bs4 import BeautifulSoup
3-
from urllib.parse import urljoin, urlparse
4-
from pydantic import Field, ConfigDict
5-
from typing import List, Optional
61
from io import BytesIO
7-
8-
from loguru import logger
2+
from typing import List, Optional
3+
from urllib.parse import urljoin
94

105
import requests
6+
from bs4 import BeautifulSoup
7+
from loguru import logger
8+
from PIL import Image
9+
from pydantic import ConfigDict, Field
1110

1211
from guidellm.config import settings
1312
from guidellm.core.serializable import Serializable
@@ -19,14 +18,14 @@ class ImageDescriptor(Serializable):
1918
A class to represent image data in serializable format.
2019
"""
2120
model_config = ConfigDict(arbitrary_types_allowed=True)
22-
21+
2322
url: Optional[str] = Field(description="url address for image.")
2423
image: Image.Image = Field(description="PIL image", exclude=True)
2524
filename: Optional[int] = Field(
2625
default=None,
2726
description="Image filename.",
2827
)
29-
28+
3029

3130
def load_images(data: str) -> List[ImageDescriptor]:
3231
"""
@@ -45,25 +44,25 @@ def load_images(data: str) -> List[ImageDescriptor]:
4544
response = requests.get(data, timeout=settings.request_timeout)
4645
response.raise_for_status()
4746

48-
soup = BeautifulSoup(response.text, 'html.parser')
47+
soup = BeautifulSoup(response.text, "html.parser")
4948
for img_tag in soup.find_all("img"):
5049
img_url = img_tag.get("src")
5150

5251
if img_url:
5352
# Handle relative URLs
5453
img_url = urljoin(data, img_url)
55-
54+
5655
# Download the image
5756
logger.debug("Loading image: {}", img_url)
5857
img_response = requests.get(img_url)
5958
img_response.raise_for_status()
60-
59+
6160
# Load image into Pillow
6261
images.append(
6362
ImageDescriptor(
64-
url=img_url,
63+
url=img_url,
6564
image=Image.open(BytesIO(img_response.content)),
6665
)
6766
)
6867

69-
return images
68+
return images

0 commit comments

Comments
 (0)