Skip to content

Commit fbe1ef1

Browse files
authored
Merge pull request #23 from vitekkor/#22_fix-http-status-on-auth-failure
Resolves #22: return Http status 401 instead of 403 on authorization failure
2 parents 907d706 + 5876c5c commit fbe1ef1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/kotlin/com/vitekkor/frogapi/controller/ApiController.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ApiController(
3232
) = withContext(Dispatchers.IO) {
3333
logger.info("Incoming frog request with token $token")
3434
val tokenFromDB = tokenService.getToken(token) ?: kotlin.run {
35-
httpServletResponse.status = 403
35+
httpServletResponse.status = 401
3636
return@withContext
3737
}
3838
tokenFromDB.requests++
@@ -60,7 +60,7 @@ class ApiController(
6060
userRepository.findOneByEmail(email)
6161
}
6262
if (user == null || user.password != password.encodeBase64()) {
63-
return ResponseEntity.status(HttpStatus.FORBIDDEN).build()
63+
return ResponseEntity.status(HttpStatus.UNAUTHORIZED).build()
6464
}
6565
val newToken = tokenService.generateToken(user)
6666
tokenService.saveToken(newToken)

0 commit comments

Comments
 (0)