HMR not triggered on creation/deletion of files

[codepunkt]

I'm a little bit confused that vite is not calling my plugins handleHotUpdate method on creation/deletion of files.

Is this the way it is supposed to work?

[Shinigami92]

Could you please provide e.g. a minimal reproduction so it's easier to understand and dive into your problem.
Currently we or other possible contributors have to few info to really help you.

The code-lines I found to the term handleHotUpdate are also not that many (https://github.com/vitejs/vite/search?q=handleHotUpdate)
Have a look into them (ignore playground and docs, and if not using plugin-vue ignore also this one)

Ignoring the mentioned parts you are left with only:

vite/packages/vite/src/node/plugin.ts

Lines 113 to 115 in ed16488

	handleHotUpdate?(
	ctx: HmrContext
	): Array<ModuleNode> | void | Promise<Array<ModuleNode> | void>

^^ looks like only a typedef ^^

and

vv This is the only code related that is not plugin-vue specific! vv

vite/packages/vite/src/node/server/hmr.ts

Lines 89 to 96 in ed16488

	for (const plugin of config.plugins) {
	if (plugin.handleHotUpdate) {
	const filteredModules = await plugin.handleHotUpdate(hmrContext)
	if (filteredModules) {
	hmrContext.modules = filteredModules
	}
	}
	}

---

So may you currently ask for a new feature request here?

[codepunkt]

I was just wondering if I'm wrong and missed something.

It seems really strange that handleHotUpdate on a plugin is only called when an existing file is changed and not when one is added or deleted.

I want this behaviour confirmed. If it is, and I'm not missing something, I'll open a feature request issue and maybe also a PR.

[PiyushSuthar]

I guess the issue might be over here

vite/packages/vite/src/node/server/index.ts

Lines 414 to 433 in 6b98fdd

	watcher.on('change', async (file) => {
	file = normalizePath(file)
	// invalidate module graph cache on file change
	moduleGraph.onFileChange(file)
	if (serverConfig.hmr !== false) {
	try {
	await handleHMRUpdate(file, server)
	} catch (err) {
	ws.send({
	type: 'error',
	err: prepareError(err)
	})
	}
	}
	})
	watcher.on('add', (file) => {
	handleFileAddUnlink(normalizePath(file), server)
	})

handleHotUpdate is only triggered when a file changes.

[maxsatula]

Hi everyone, I can rationalize a need in a new feature request why I would want HMR to be triggered on creation/deletion of files.

I'm writing a virtual module which gathers a directory tree of .sql files and exports a single JS object with keys representing directory/file names and values are file contents (or a nested object if it is a directory). So, I'd like that any creation/deletion of a file to trigger my HMR.