Throwing error from handleHotUpdate is ignored

[kocv59]

I throw an error from handleHotUpdate (for a YAML file not a real module) and I wanted the hot reload to fail and show the error in the browser. It shows it for a second then reloads and shows the the error is gone. How can I make Vite know the file it wants to reload is invalid and should fail?

[hi-ogawa]

From my experience, throwing an error during handleHotUpdate or hotUpdate should halt default hmr / reload logic, so nothing should happen after that. For example, I do something like this for rsc plugin https://github.com/vitejs/vite-plugin-react/blob/2b7b90f9ee94ca70beda90f288df2a5b6b260900/packages/plugin-rsc/src/plugin.ts#L630-L638.
Can you provide a reproduction if that's not that case?

[kocv59]

Why does hot reload need to stop? If the failure is because of an invalid file when the file is fixed the next hot reload can work.

The console doesn't show the error in handleHotUpdate but that should be added.

Is there a way to show a browser overlay with Vite errors in the browser so I can see if in the browser the hot reload fails? Even if it is there in the console you might not check it.

The error shows in the Astro error overlay for a second then reloads but that might be something to fix on the Astro end.

[hi-ogawa]

throwing an error during handleHotUpdate or hotUpdate should halt default hmr / reload logic, so nothing should happen after that.

Why does hot reload need to stop? If the failure is because of an invalid file when the file is fixed the next hot reload can work.

Maybe my wording was off. To clarify, what I meant is that, the failure during handleHotUpdate becomes no-op, but next successful handleHotUpdate should work as usual.

---

Again, it's not clear what exact behavior you are referring to, so it would be nice if you can provide a reproduction to understand the situation better.

[kocv59]

It happens with a minimal plugin. The error is thrown but the Vite console doesn't show an error and nothing in the browser so you don't know an error happened.

return {
  name: "errorplugin",
  handleHotUpdate: () => {
    throw new Error("error")
  }
}

[hi-ogawa]

Yup, that's the current behavior. Just looking back https://github.com/vitejs/vite-plugin-react/blob/2b7b90f9ee94ca70beda90f288df2a5b6b260900/packages/plugin-rsc/src/plugin.ts#L630-L638, I think it might be fine with this being the default behavior of Vite. Please feel free to create an issue.