Add page borders

[superlou]

Using version 0.6.3, documents do not have page borders.

This can make it hard to know when the content ends, and generally not feel grounds when reading through a document. It would be helpful to have an option that clearly delineates document pages. For example:

[vincent-uden]

Thank you for the comment and the visual feeback.

I like the borderless look and I also like just seeing on page at a time (i navigate between them using forwards and backwards on the mouse if I use the mouse).

I am however open to the possibility of something like you showed here as an option, perhaps even the default one depending on what people would expect. It should be pretty easy to implement.

Questions I have:

• Should the color of the background be tied to the pdf color or the interface color?
• Should toggling between borderless and bordered pages have a keybinding, if so; what?

[superlou]

I'm definitely of two minds on borders. When I'm looking at drawings and diagrams, the borderless look is nice. When I'm reading multi-page documents, I feel "floaty" if there isn't some indication of the page boundaries.

• Should the color of the background be tied to the pdf color or the interface color?

I think I overemphasized the background color compared to what a good UI designer might have done, but I think my expectation would be tied to light/dark mode more than the PDF color. I don't think users would want a severe contrast between the page and the background. Maybe the only scenario I can think of where a large contrast might be helpful is if you're showing something in a full-screen scenario, and want the background to be black. Do PDFs have data indicating background color of a page?

• Should toggling between borderless and bordered pages have a keybinding, if so; what?

I don't think it would be something I would toggle often enough to need a keybinding, so I don't think I'd need a default keybinding. If users could add custom bindings, that seems to match the philosophy of the project.

Thanks for the considering this, and I'm definitely not an authoritative source. I wasn't actually thinking about being able to show multiple pages on screen, but when reading documents, it is sometimes nice to smoothly scroll down as I'm reading. That's probably worth a separate issue for consideration. With only a single page visible, if the page is zoomed in (not entirely visible on the screen), at the end of each page, it's a jump back to the top for the next page.

[vincent-uden]

Do PDFs have data indicating background color of a page?

Some do, some dont. I always prefill the background with white pixels anyways since PDFs with transparent backgrounds are (pretty much) always assumed to be displayed in a viewer with a black background.

That's probably worth a separate issue for consideration.

Agreed.

I don't think users would want a severe contrast between the page and the background.

This makes sense. Huge differences in contrast hurt look at. A slightly lighter or darker version of the page background color is probably what we want.