Type error: Duplicate property 'play' since version 2.29.4

[awidmer-hf]

Hey everybody

This week I tried to build my project, and got following error:

#20 16.70 ./node_modules/@vimeo/player/types/events.ts:226:5 #20 16.70 Type error: Duplicate property 'play'. #20 16.70 #20 16.70 224 | /** Maps event names to their corresponding event data types */ #20 16.70 225 | export interface PlayerEventMap { #20 16.70 > 226 | [PlayerEvent.Play]: VimeoEvent; #20 16.70 | ^ #20 16.70 227 | play: VimeoEvent;// #20 16.70 228 | [PlayerEvent.Pause]: VimeoEvent; #20 16.70 229 | pause: VimeoEvent;

I was searching for hours, until I found out, that this appears since version 2.29.4.
When freezing the version to 2.29.3 everthing seems to work properly.

Could you please check if this is a major problem?
I'd like to be able to update the player to the next versions if possible.

Thx.
Adrian

[jdreetz]

Hey @awidmer-hf can you test with this branch and see if the issue is still present - https://github.com/vimeo/player.js/tree/types-cleanup . This branch fixes a few issues with types introduced in 2.29.5.

[awidmer-hf]

Hi @jdreetz thanks for your quick response.
I tested with this branch and the build seems to work now, without any type errors.
Hope you will publish a.s.a.p.
Thx very much.

[jdreetz]

@awidmer-hf that branch was merged into 2.29.6. Let me know if you're still seeing issues with that release.