Enums not exported

[mwiest]

With the added types in 2.29.4, I would expect to be able to do something like this, instead of using strings like "play".

player.on(PlayerEvent.Play, (e) => updateProgress(e));
player.on(PlayerEvent.TimeUpdate, (e) => updateProgress(e));
player.on(PlayerEvent.Ended, (e) => updateProgress(e));

But, unfortunately, while player.d.ts exports this enum via export * from ./events.ts, this doesn't work, because the enum cannot be imported as a "thing" in JS for runtime. player.es.js doesn't export it. I'm not very good at TS, so, I may be missing something, but I thought I'd mention it. For now, I'm still using strings.

[jdreetz]

@mwiest can you try with this branch and see if the issue still exists? https://github.com/vimeo/player.js/tree/types-cleanup. It removes the enums and just uses strings for event names, like how we previously did it.

[jdreetz]

@mwiest we ended up removing the Enums in 2.26.6 since they're not compatible with the erasableSyntaxOnly Typescript option. So you'll have to use strings again. Let me know if you're still having issues with this.

[mwiest]

@jdreetz I've already replaced the enums with strings again, since it was not working for me. TS enums are a strange thing and I would support not using them. I've used string union types instead in the past, maybe that's a viable option.

[jdreetz]

@jdreetz I've already replaced the enums with strings again, since it was not working for me. TS enums are a strange thing and I would support not using them. I've used string union types instead in the past, maybe that's a viable option.

Yea, it seems like people are moving away from them, so since this was so new I think it made sense not to support them.