Skip to content

Commit 5b23d4d

Browse files
committed
🌿 Fix type error caused by rid removal in Deno v2
1 parent 3a7f3bd commit 5b23d4d

File tree

2 files changed

+22
-6
lines changed

2 files changed

+22
-6
lines changed

tests/denops/testutil/mock.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ export function pendingPromise(): Promise<never> {
77
}
88

99
/** Returns a fake `TcpListener` instance. */
10-
export function createFakeTcpListener(): Deno.TcpListener {
10+
// NOTE: 'rid' is removed from Deno v2
11+
export function createFakeTcpListener(): { rid: unknown } & Deno.TcpListener {
1112
let closeWaiter: PromiseWithResolvers<never> | undefined = Promise
1213
.withResolvers();
1314
closeWaiter.promise.catch(() => {});
@@ -54,7 +55,8 @@ export function createFakeTcpListener(): Deno.TcpListener {
5455
}
5556

5657
/** Returns a fake `TcpConn` instance. */
57-
export function createFakeTcpConn(): Deno.TcpConn {
58+
// NOTE: 'rid' is removed from Deno v2
59+
export function createFakeTcpConn(): { rid: unknown } & Deno.TcpConn {
5860
return {
5961
get localAddr() {
6062
return unimplemented();

tests/denops/testutil/mock_test.ts

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,11 @@ Deno.test("createFakeTcpListener()", async (t) => {
5757
close: 0,
5858
[Symbol.asyncIterator]: 0,
5959
[Symbol.dispose]: 0,
60-
} as const satisfies Record<keyof Deno.TcpListener, 0>,
60+
} as const satisfies Record<
61+
// NOTE: 'rid' is removed from Deno v2
62+
keyof { rid: unknown } & Deno.TcpListener,
63+
0
64+
>,
6165
);
6266
for (const key of keys) {
6367
await t.step(key.toString(), () => {
@@ -70,7 +74,10 @@ Deno.test("createFakeTcpListener()", async (t) => {
7074
const unimplementedProps = [
7175
"addr",
7276
"rid",
73-
] as const satisfies readonly GetterKeyOf<Deno.TcpListener>[];
77+
] as const satisfies readonly GetterKeyOf<
78+
// NOTE: 'rid' is removed from Deno v2
79+
{ rid: unknown } & Deno.TcpListener
80+
>[];
7481
for (const key of unimplementedProps) {
7582
await t.step(`.${key}`, () => {
7683
assertThrows(() => listener[key], Error, "Unimplemented");
@@ -230,7 +237,11 @@ Deno.test("createFakeTcpConn()", async (t) => {
230237
close: 0,
231238
closeWrite: 0,
232239
[Symbol.dispose]: 0,
233-
} as const satisfies Record<keyof Deno.TcpConn, 0>,
240+
} as const satisfies Record<
241+
// NOTE: 'rid' is removed from Deno v2
242+
keyof { rid: unknown } & Deno.TcpConn,
243+
0
244+
>,
234245
);
235246
for (const key of keys) {
236247
await t.step(key.toString(), () => {
@@ -246,7 +257,10 @@ Deno.test("createFakeTcpConn()", async (t) => {
246257
"rid",
247258
"readable",
248259
"writable",
249-
] as const satisfies readonly GetterKeyOf<Deno.TcpConn>[];
260+
] as const satisfies readonly GetterKeyOf<
261+
// NOTE: 'rid' is removed from Deno v2
262+
{ rid: unknown } & Deno.TcpConn
263+
>[];
250264
for (const key of unimplementedProps) {
251265
await t.step(`.${key}`, () => {
252266
assertThrows(() => conn[key], Error, "Unimplemented");

0 commit comments

Comments
 (0)