🐛 Fix boolean option getter returns true|false instead 1|0

Fixes #203

Author: Milly

scripts/gen-option/format.ts

@@ -24,6 +24,22 @@ function defaultValue(type: OptionType): string {
   }
 }
 
+function coerceValue(expr: string, type: OptionType): string {
+  switch (type) {
+    case "string":
+      return `(${expr}) as string`;
+    case "number":
+      return `(${expr}) as number`;
+    case "boolean":
+      // Vim returns (0 | 1) so coerce to boolean.
+      return `Boolean(${expr})`;
+    default: {
+      const unknownType: never = type;
+      throw new Error(`Unknown type ${unknownType}`);
+    }
+  }
+}
+
 export function formatDocs(docs: string): string[] {
   const lines = docs.replaceAll(/\*\//g, "* /").split("\n");
   const normalizedLines = lines.map((v) => ` * ${v}`.trimEnd());
@@ -49,7 +65,8 @@ function formatOption({ name, type, scope, docs }: Option): string[] {
 function formatOptionBody(name: string, type: OptionType): string[] {
   const lines = [
     `  async get(denops: Denops): Promise<${type}> {`,
-    `    return await options.get(denops, "${name}") ?? ${defaultValue(type)};`,
+    `    const result = await options.get(denops, "${name}");`,
+    `    return ${coerceValue(`result ?? ${defaultValue(type)}`, type)};`,
     `  },`,
     `  set(denops: Denops, value: ${type}): Promise<void> {`,
     `    return options.set(denops, "${name}", value);`,
@@ -64,9 +81,8 @@ function formatOptionBody(name: string, type: OptionType): string[] {
 function formatGlobalOptionBody(name: string, type: OptionType): string[] {
   const lines = [
     `  async getGlobal(denops: Denops): Promise<${type}> {`,
-    `    return await globalOptions.get(denops, "${name}") ?? ${
-      defaultValue(type)
-    };`,
+    `    const result = await globalOptions.get(denops, "${name}");`,
+    `    return ${coerceValue(`result ?? ${defaultValue(type)}`, type)};`,
     `  },`,
     `  setGlobal(denops: Denops, value: ${type}): Promise<void> {`,
     `    return globalOptions.set(denops, "${name}", value);`,
@@ -81,9 +97,8 @@ function formatGlobalOptionBody(name: string, type: OptionType): string[] {
 function formatLocalOptionBody(name: string, type: OptionType): string[] {
   const lines = [
     `  async getLocal(denops: Denops): Promise<${type}> {`,
-    `    return await localOptions.get(denops, "${name}") ?? ${
-      defaultValue(type)
-    };`,
+    `    const result = await localOptions.get(denops, "${name}");`,
+    `    return ${coerceValue(`result ?? ${defaultValue(type)}`, type)};`,
     `  },`,
     `  setLocal(denops: Denops, value: ${type}): Promise<void> {`,
     `    return localOptions.set(denops, "${name}", value);`,
@@ -99,7 +114,7 @@ function formatBufferOptionBody(name: string, type: OptionType): string[] {
   const lines = [
     `  async getBuffer(denops: Denops, bufnr: number): Promise<${type}> {`,
     `    const result = await getbufvar(denops, bufnr, "&${name}");`,
-    `    return (result as ${type}) ?? ${defaultValue(type)};`,
+    `    return ${coerceValue(`result ?? ${defaultValue(type)}`, type)};`,
     `  },`,
     `  setBuffer(denops: Denops, bufnr: number, value: ${type}): Promise<void> {`,
     `    return setbufvar(denops, bufnr, "&${name}", value);`,
@@ -112,7 +127,7 @@ function formatWindowOptionBody(name: string, type: OptionType): string[] {
   const lines = [
     `  async getWindow(denops: Denops, winnr: number): Promise<${type}> {`,
     `    const result = await getwinvar(denops, winnr, "&${name}");`,
-    `    return (result as ${type}) ?? ${defaultValue(type)};`,
+    `    return ${coerceValue(`result ?? ${defaultValue(type)}`, type)};`,
     `  },`,
     `  setWindow(denops: Denops, winnr: number, value: ${type}): Promise<void> {`,
     `    return setwinvar(denops, winnr, "&${name}", value);`,