👍 Use UppserCase in percent encoded characters

While `URL` or `URLSearchParams` use UppserCase.

Author: lambdalisue

denops_std/bufname/bufname.ts

@@ -35,7 +35,7 @@ export function format({ scheme, path, params, fragment }: Bufname): string {
       `Scheme '${scheme}' contains unusable characters. Only alphabets are allowed.`,
     );
   }
-  const encodedPath = encode(path).replaceAll(";", "%3b").replaceAll(
+  const encodedPath = encode(path).replaceAll(";", "%3B").replaceAll(
     "#",
     "%23",
   );
@@ -68,7 +68,7 @@ export function parse(expr: string): Bufname {
     );
   }
   const remain = decode(expr.substring(`${scheme}://`.length), [
-    "%3b", // ;
+    "%3B", // ;
     "%23", // #
   ]);
   const m2 = remain.match(pathPattern)!;

denops_std/bufname/bufname_test.ts

@@ -63,7 +63,7 @@ Deno.test("format encodes unusable characters in 'path'", () => {
     path: "/<>|?*",
   };
   const dst = format(src);
-  const exp = "denops:///%3c%3e%7c%3f%2a";
+  const exp = "denops:///%3C%3E%7C%3F%2A";
   assertEquals(dst, exp);
 });
 Deno.test("format returns buffer name string from Bufname instance (with URLSearchParams)", () => {
@@ -89,7 +89,7 @@ Deno.test("format encodes unusable characters in 'params'", () => {
     },
   };
   const dst = format(src);
-  const exp = "denops:///absolute/path/to/worktree;foo=%3C%3E%7C%3F%2a";
+  const exp = "denops:///absolute/path/to/worktree;foo=%3C%3E%7C%3F%2A";
   assertEquals(dst, exp);
 });
 Deno.test("format returns buffer name string from Bufname instance (with fragment)", () => {
@@ -109,7 +109,7 @@ Deno.test("format encodes unusable characters in 'fragment'", () => {
     fragment: "<>|?*",
   };
   const dst = format(src);
-  const exp = "denops:///absolute/path/to/worktree#%3c%3e%7c%3f%2a";
+  const exp = "denops:///absolute/path/to/worktree#%3C%3E%7C%3F%2A";
   assertEquals(dst, exp);
 });
 Deno.test("format returns buffer name string from Bufname instance (with URLSearchParams and fragment)", () => {
@@ -134,7 +134,7 @@ Deno.test("format encodes ';' and '#' in 'path'", () => {
     path: "/hello;world#hello",
   };
   const dst = format(src);
-  const exp = "denops:///hello%3bworld%23hello";
+  const exp = "denops:///hello%3Bworld%23hello";
   assertEquals(dst, exp);
 });
 
@@ -185,7 +185,7 @@ Deno.test("parse returns Bufname instance from buffer name", () => {
   assertEquals(dst, exp);
 });
 Deno.test("parse decodes percent-encoded characters in 'path'", () => {
-  const src = "denops:///%3c%3e%7c%3f%2a";
+  const src = "denops:///%3C%3E%7C%3F%2A";
   const dst = parse(src);
   const exp = {
     scheme: "denops",
@@ -207,7 +207,7 @@ Deno.test("parse returns Bufname instance from buffer name (with params)", () =>
   assertEquals(dst, exp);
 });
 Deno.test("parse decodes percent-encoded characters in 'params'", () => {
-  const src = "denops:///absolute/path/to/worktree;foo=%3C%3E%7C%3F%2a";
+  const src = "denops:///absolute/path/to/worktree;foo=%3C%3E%7C%3F%2A";
   const dst = parse(src);
   const exp = {
     scheme: "denops",
@@ -229,7 +229,7 @@ Deno.test("parse returns Bufname instance from buffer name (with fragment)", ()
   assertEquals(dst, exp);
 });
 Deno.test("parse decodes percent-encoded characters in 'fragment'", () => {
-  const src = "denops:///absolute/path/to/worktree#%3c%3e%7c%3f%2a";
+  const src = "denops:///absolute/path/to/worktree#%3C%3E%7C%3F%2A";
   const dst = parse(src);
   const exp = {
     scheme: "denops",
@@ -254,7 +254,7 @@ Deno.test("parse returns Bufname instance from buffer name (with params and frag
   assertEquals(dst, exp);
 });
 Deno.test("parse decode percent-encoded characters (';' and '#') in 'path'", () => {
-  const src = "denops:///hello%3bworld%23hello";
+  const src = "denops:///hello%3Bworld%23hello";
   const dst = parse(src);
   const exp = {
     scheme: "denops",

denops_std/bufname/utils.ts

@@ -10,7 +10,7 @@ const encodedCharacterPattern = /(?:%[0-9a-fA-F]{2})+/g;
 export function encode(expr: string): string {
   expr = expr.replaceAll(
     bufnameUnusablePattern,
-    (c) => `%${c.codePointAt(0)!.toString(16)}`,
+    (c) => `%${c.codePointAt(0)!.toString(16).toUpperCase()}`,
   );
   return expr;
 }
@@ -19,10 +19,11 @@ export function encode(expr: string): string {
  * Decode all percent-encoded characters.
  */
 export function decode(expr: string, excludes?: string[]): string {
+  excludes = (excludes ?? []).map((v) => v.toUpperCase());
   expr = expr.replaceAll(
     encodedCharacterPattern,
     (m) => {
-      if (excludes?.includes(m.toLowerCase())) {
+      if (excludes?.includes(m.toUpperCase())) {
         return m;
       }
       return decodeURIComponent(m);

denops_std/bufname/utils_test.ts

@@ -16,7 +16,7 @@ Deno.test("encode does nothing on numeric characters", () => {
 Deno.test('encode encodes some symbol characters ("<>|?*)', () => {
   const src = " !\"#$%&'()*+,-./:;<=>?@[\\]^`{|}~";
   const dst = encode(src);
-  const exp = " !%22#$%&'()%2a+,-./:;%3c=%3e%3f@[\\]^`{%7c}~";
+  const exp = " !%22#$%&'()%2A+,-./:;%3C=%3E%3F@[\\]^`{%7C}~";
   assertEquals(dst, exp);
 });
 Deno.test("encode does nothing on 日本語", () => {
@@ -45,7 +45,7 @@ Deno.test("decode does nothing on numeric characters", () => {
   assertEquals(dst, exp);
 });
 Deno.test('decode decodes encoded characters ("<>|?*)', () => {
-  const src = " !%22#$%&'()%2a+,-./:;%3c=%3e%3f@[\\]^`{%7c}~";
+  const src = " !%22#$%&'()%2A+,-./:;%3C=%3E%3F@[\\]^`{%7C}~";
   const dst = decode(src);
   const exp = " !\"#$%&'()*+,-./:;<=>?@[\\]^`{|}~";
   assertEquals(dst, exp);