Merge pull request #175 from vim-denops/support-bang

👍 Add `bang` option on `buffer.open` function

Author: lambdalisue

denops_std/buffer/buffer.ts

@@ -24,8 +24,8 @@ async function ensurePrerequisites(denops: Denops): Promise<string> {
   }
   denops.context[cacheKey] = true;
   const script = `
-  function! DenopsStdBufferOpen_${suffix}(mods, opener, cmdarg, bufname) abort
-    execute printf('%s %s %s \`=a:bufname\`', a:mods, a:opener, a:cmdarg)
+  function! DenopsStdBufferOpen_${suffix}(bang, mods, opener, cmdarg, bufname) abort
+    execute printf('%s %s%s %s \`=a:bufname\`', a:mods, a:opener, a:bang ? '!' : '', a:cmdarg)
     return {
           \\ 'winid': win_getid(),
           \\ 'bufnr': bufnr(),
@@ -186,11 +186,13 @@ export async function open(
   options: OpenOptions = {},
 ): Promise<OpenResult> {
   const suffix = await ensurePrerequisites(denops);
+  const bang = options.bang ?? false;
   const mods = options.mods ?? "";
   const cmdarg = options.cmdarg ?? "";
   const opener = options.opener ?? "edit";
   return await denops.call(
     `DenopsStdBufferOpen_${suffix}`,
+    bang,
     mods,
     opener,
     cmdarg,
@@ -199,6 +201,7 @@ export async function open(
 }
 
 export interface OpenOptions {
+  bang?: boolean;
   mods?: string;
   cmdarg?: string;
   opener?: string;

denops_std/buffer/buffer_test.ts

@@ -1,4 +1,7 @@
-import { assertEquals } from "https://deno.land/std@0.171.0/testing/asserts.ts";
+import {
+  assertEquals,
+  assertRejects,
+} from "https://deno.land/std@0.171.0/testing/asserts.ts";
 import { test } from "https://deno.land/x/denops_test@v1.0.1/mod.ts";
 import { default as Encoding } from "https://cdn.skypack.dev/encoding-japanese@2.0.0/";
 import * as fn from "../function/mod.ts";
@@ -59,6 +62,32 @@ test({
             assertEquals(await fn.tabpagenr(denops), info.tabpagenr);
           },
         });
+        await t.step({
+          name: "opens a new buffer fails when modified (nohidden)",
+          fn: async () => {
+            await denops.cmd("set modified nohidden");
+            await assertRejects(
+              () => open(denops, "Hello world"),
+              Error,
+              "No write since last change (add ! to override)",
+            );
+            await denops.cmd("set nomodified");
+          },
+        });
+        await t.step({
+          name: "opens a new buffer when modified with bang (nohidden)",
+          fn: async () => {
+            await denops.cmd("set modified nohidden");
+            const info = await open(denops, "Hello world", { bang: true });
+            const bufname = await fn.bufname(denops);
+            assertEquals("Hello world", bufname);
+            assertEquals(await fn.win_getid(denops), info.winid);
+            assertEquals(await fn.bufnr(denops), info.bufnr);
+            assertEquals(await fn.winnr(denops), info.winnr);
+            assertEquals(await fn.tabpagenr(denops), info.tabpagenr);
+            await denops.cmd("set nomodified");
+          },
+        });
       },
     });