all eslint errors are fixed

Author: vigneshwaran-chandrasekaran

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npm run lint-staged

README.md

@@ -6,40 +6,47 @@ In the project directory, you can run:
 
 ### `yarn start`
 
-Runs the app in the development mode.<br />
-Open [http://localhost:3000](http://localhost:3000) to view it in the browser.
+Runs the app in the development mode.<br /> Open [http://localhost:3000](http://localhost:3000) to
+view it in the browser.
 
-The page will reload if you make edits.<br />
-You will also see any lint errors in the console.
+The page will reload if you make edits.<br /> You will also see any lint errors in the console.
 
 ### `yarn test`
 
-Launches the test runner in the interactive watch mode.<br />
-See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.
+Launches the test runner in the interactive watch mode.<br /> See the section about
+[running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more
+information.
 
 ### `yarn build`
 
-Builds the app for production to the `build` folder.<br />
-It correctly bundles React in production mode and optimizes the build for the best performance.
+Builds the app for production to the `build` folder.<br /> It correctly bundles React in production
+mode and optimizes the build for the best performance.
 
-The build is minified and the filenames include the hashes.<br />
-Your app is ready to be deployed!
+The build is minified and the filenames include the hashes.<br /> Your app is ready to be deployed!
 
-See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.
+See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for
+more information.
 
 ### `yarn eject`
 
 **Note: this is a one-way operation. Once you `eject`, you can’t go back!**
 
-If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
+If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time.
+This command will remove the single build dependency from your project.
 
-Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.
+Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel,
+ESLint, etc) right into your project so you have full control over them. All of the commands except
+`eject` will still work, but they will point to the copied scripts so you can tweak them. At this
+point you’re on your own.
 
-You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
+You don’t have to ever use `eject`. The curated feature set is suitable for small and middle
+deployments, and you shouldn’t feel obligated to use this feature. However we understand that this
+tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
 
 ## Learn More
 
-You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
+You can learn more in the
+[Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
 
 To learn React, check out the [React documentation](https://reactjs.org/).
 
@@ -49,11 +56,13 @@ This section has moved here: https://facebook.github.io/create-react-app/docs/co
 
 ### Analyzing the Bundle Size
 
-This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
+This section has moved here:
+https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
 
 ### Making a Progressive Web App
 
-This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
+This section has moved here:
+https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
 
 ### Advanced Configuration
 
@@ -65,4 +74,5 @@ This section has moved here: https://facebook.github.io/create-react-app/docs/de
 
 ### `yarn build` fails to minify
 
-This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify
+This section has moved here:
+https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify

README.old.md

@@ -1 +1 @@
-# todo-app-hackerearth
+# todo-app-hackerearth

package.json

@@ -76,7 +76,7 @@
     "eslint-plugin-react": "^7.27.1",
     "eslint-plugin-react-hooks": "^4.3.0",
     "fs": "0.0.1-security",
-    "husky": "^7.0.4",
+    "husky": "^7.0.0",
     "jest": "^26.6.3",
     "lint-staged": "^12.1.2",
     "path": "^0.12.7",

public/my-serviceworker.js

@@ -1,3 +1,5 @@
+/* eslint-disable array-callback-return */
+/* eslint-disable consistent-return */
 const CACHE_NAME = 'version-1';
 const urlsToCache = [
 	'/',

src/components/common/ErrorBoundary.js

@@ -1,5 +1,6 @@
 import React, { Component } from 'react';
-// import { Link } from 'react-router-dom';
+import { Link } from 'react-router-dom';
+import PropTypes from 'prop-types';
 
 export default class ErrorBoundary extends Component {
 	constructor(props) {
@@ -19,16 +20,23 @@ export default class ErrorBoundary extends Component {
 	}
 
 	render() {
-		if (this.state.hasError) {
+		const { hasError } = this.state;
+		const { children } = this.props;
+
+		if (hasError) {
 			// You can render any custom fallback UI
 			return (
 				<div className="center">
 					<h1 className="center p-20 warn gr-bc">Sorry something went wrong.</h1>
-					{/* <Link to="/logout">Logout</Link> */}
+					<Link to="/logout">Logout</Link>
 				</div>
 			);
 		}
 
-		return this.props.children;
+		return children;
 	}
 }
+
+ErrorBoundary.propTypes = {
+	children: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node]),
+};

src/components/common/Loader.js

@@ -16,12 +16,12 @@ export default function Loader() {
 	};
 
 	return (
-		<>
+		<div>
 			{loader && (
 				<div className="loaderbox">
 					<Lottie options={defaultOptions} height={128} width={128} />
 				</div>
 			)}
-		</>
+		</div>
 	);
 }

src/components/routes/AuthRoute.js

@@ -1,5 +1,6 @@
 import React from 'react';
 import { Route, Redirect } from 'react-router-dom';
+import PropTypes from 'prop-types';
 import { SESSION } from '../../services';
 
 function AuthRoute({ children, ...rest }) {
@@ -15,4 +16,8 @@ function AuthRoute({ children, ...rest }) {
 	return <Route {...rest}>{children}</Route>;
 }
 
+AuthRoute.propTypes = {
+	children: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node]).isRequired,
+};
+
 export default AuthRoute;

src/components/routes/PrivateRoute.js

@@ -2,6 +2,7 @@ import { Layout } from 'antd';
 import React, { useEffect } from 'react';
 import { useDispatch } from 'react-redux';
 import { Route } from 'react-router-dom';
+import PropTypes from 'prop-types';
 import { SESSION } from '../../services';
 // import { Sidebar } from '../sidebar';
 import { HeadNavbar } from '../common';
@@ -42,4 +43,9 @@ function PrivateRoute({ children, location, ...rest }) {
 	SESSION.logout();
 }
 
+PrivateRoute.propTypes = {
+	location: PropTypes.object,
+	children: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node]).isRequired,
+};
+
 export default PrivateRoute;

src/components/sidebar/Sidebar.js

@@ -1,44 +1,47 @@
 import React, { useState, useEffect } from 'react';
 import { Layout, Menu } from 'antd';
+import PropTypes from 'prop-types';
 import { NavLink, withRouter } from 'react-router-dom';
 import { PoweroffOutlined, HighlightOutlined } from '@ant-design/icons';
 import { findUrlPathId, handleLogout } from './Sidebar.controller';
 
 const { Sider } = Layout;
 
-function Sidebar(props) {
+function Sidebar({ location }) {
 	const [collapsed, setCollapsed] = useState(false);
 	const [key, setKey] = useState();
 
 	useEffect(() => {
-		const path = props.location.pathname;
-		const pathId = findUrlPathId(path);
+		const { pathname } = location;
+		const pathId = findUrlPathId(pathname);
 		setKey(pathId);
 		// eslint-disable-next-line react-hooks/exhaustive-deps
-	}, [props.location.pathname]);
+	}, [location.pathname]);
 
-	function onCollapse(collapsed) {
-		setCollapsed(collapsed);
+	function onCollapse(data) {
+		setCollapsed(data);
 	}
 
 	return (
 		<Sider collapsible collapsed={collapsed} onCollapse={onCollapse}>
-			<>
-				<Menu theme="dark" mode="inline" defaultSelectedKeys={[key]} selectedKeys={[key]}>
-					<Menu.Item key="1">
-						<NavLink to="/todo" />
-						<HighlightOutlined />
-						<span>Todo</span>
-					</Menu.Item>
-
-					<Menu.Item key="4" onClick={handleLogout}>
-						<PoweroffOutlined />
-						<span>Log Out</span>
-					</Menu.Item>
-				</Menu>
-			</>
+			<Menu theme="dark" mode="inline" defaultSelectedKeys={[key]} selectedKeys={[key]}>
+				<Menu.Item key="1">
+					<NavLink to="/todo" />
+					<HighlightOutlined />
+					<span>Todo</span>
+				</Menu.Item>
+
+				<Menu.Item key="4" onClick={handleLogout}>
+					<PoweroffOutlined />
+					<span>Log Out</span>
+				</Menu.Item>
+			</Menu>
 		</Sider>
 	);
 }
 
+Sidebar.propTypes = {
+	location: PropTypes.object,
+};
+
 export default withRouter(Sidebar);

src/components/todo/TodoBox.js

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 import { TodoDate, TodoActionControls, TodoLabel } from '.';
 
 export default function TodoBox(props) {
@@ -14,3 +15,10 @@ export default function TodoBox(props) {
 		</div>
 	);
 }
+
+TodoBox.propTypes = {
+	data: PropTypes.shape({
+		title: PropTypes.string,
+		description: PropTypes.string,
+	}),
+};

src/components/todo/TodoDate.js

@@ -2,13 +2,14 @@ import React, { useState, useEffect } from 'react';
 import { Tag } from 'antd';
 import { ClockCircleOutlined } from '@ant-design/icons';
 import moment from 'moment';
+import PropTypes from 'prop-types';
 
 export default function TodoDate({ data }) {
 	const [date, setDate] = useState('Date not available');
 	useEffect(() => {
 		if (data.dueDate) {
-			const date = moment(data.dueDate).format('DD MMM YYYY');
-			setDate(date);
+			const dateNew = moment(data.dueDate).format('DD MMM YYYY');
+			setDate(dateNew);
 		}
 	}, [data]);
 
@@ -18,3 +19,10 @@ export default function TodoDate({ data }) {
 		</Tag>
 	);
 }
+
+TodoDate.propTypes = {
+	data: PropTypes.shape({
+		dueDate: PropTypes.string,
+		description: PropTypes.string,
+	}),
+};

src/components/todo/TodoDelete.js

@@ -2,6 +2,7 @@ import React from 'react';
 import { useDispatch } from 'react-redux';
 import { Button, Popconfirm, message } from 'antd';
 import { DeleteOutlined } from '@ant-design/icons';
+import PropTypes from 'prop-types';
 import { API } from '../../services';
 import { updatedTodoList } from '../../store/actions/api.actions';
 
@@ -32,3 +33,9 @@ export default function TodoDelete({ data }) {
 		</Popconfirm>
 	);
 }
+
+TodoDelete.propTypes = {
+	data: PropTypes.shape({
+		_id: PropTypes.string,
+	}),
+};

src/components/todo/TodoEdit.js

@@ -1,6 +1,7 @@
 import React from 'react';
 import { useDispatch } from 'react-redux';
 import { Button } from 'antd';
+import PropTypes from 'prop-types';
 import { EditOutlined } from '@ant-design/icons';
 import { editTodo } from '../../store/actions/api.actions';
 
@@ -13,3 +14,9 @@ export default function TodoEdit({ data }) {
 
 	return <Button onClick={handleEdit} icon={<EditOutlined />} />;
 }
+
+TodoEdit.propTypes = {
+	data: PropTypes.shape({
+		_id: PropTypes.string,
+	}),
+};

src/components/todo/TodoLabel.js

@@ -1,5 +1,6 @@
 import React, { useState, useEffect } from 'react';
 import { Tag } from 'antd';
+import PropTypes from 'prop-types';
 import { TODO_LABEL } from '../../helpers/constants';
 
 export default function TodoLabel({ data }) {
@@ -18,3 +19,9 @@ export default function TodoLabel({ data }) {
 	}, [data]);
 	return <Tag color={state.color}>{state.key}</Tag>;
 }
+
+TodoLabel.propTypes = {
+	data: PropTypes.shape({
+		label: PropTypes.string,
+	}),
+};

src/components/todo/TodoList.js

@@ -41,20 +41,20 @@ export default function TodoList() {
 		/**
 		 * find label id from selected label checkboxes
 		 */
-		const labels = TODO_LABEL.filter((label) => state.checkedList.includes(label.key)).map(
-			(todo) => todo.id
-		);
+		const labelsSelected = TODO_LABEL.filter((label) =>
+			state.checkedList.includes(label.key)
+		).map((todo) => todo.id);
 
 		/**
 		 * filter out todo based on selected labels
 		 */
-		const filtered = todos.filter((todo) => labels.includes(todo.label));
+		const filtered = todos.filter((todo) => labelsSelected.includes(todo.label));
 
 		/**
 		 * Group the todos based on status (New, inprogress, completed)
 		 */
-		const grouped = mapValues(groupBy(filtered, 'status'));
-		setGrouped(grouped);
+		const groupedFiltered = mapValues(groupBy(filtered, 'status'));
+		setGrouped(groupedFiltered);
 	}, [todos, state]);
 
 	const onChange = (checkedList) => {