SharePoint API: fields namespace improvements

Author: vvgrem@gmail.com

examples/sharepoint/tenant/get_set_site_admin.py

@@ -17,11 +17,11 @@
 admins = tenant.get_site_secondary_administrators(site_id=target_site.id)
 admin_client.execute_query()
 
-existing_admin_names = [admin.get_property('loginName') for admin in admins]
+existing_admin_names = [admin.loginName for admin in admins]
 
-target_user = target_site.rootWeb.ensure_user(f"mdoe@{tenant_prefix}.onmicrosoft.com").execute_query()
+target_user = target_site.root_web.ensure_user(f"mdoe@{tenant_prefix}.onmicrosoft.com").execute_query()
 names = existing_admin_names + [target_user.login_name]
 tenant.set_site_secondary_administrators(site_id=target_site.id, names=names).execute_query()
 
 for admin in admins:  # type: SecondaryAdministratorsInfo
-    print(admin.get_property('loginName'))
+    print(admin.loginName)

generator/metadata/SharePoint.xml

@@ -26,6 +26,9 @@ def __init__(self, context, resource_path=None, properties=None, parent_collecti
             for k, v in properties.items():
                 self.set_property(k, v, True)
 
+    def clear(self):
+        self._changed_properties = []
+
     def execute_query(self):
         self.context.execute_query()
         return self

office365/runtime/client_object.py

@@ -26,10 +26,10 @@ def from_method(method_name, method_parameters=None):
             url += "("
             if isinstance(method_parameters, dict):
                 url += ','.join(['%s=%s' % (key, ODataPathParser.encode_method_value(value)) for (key, value) in
-                                 method_parameters.items()])
+                                 method_parameters.items() if value is not None])
             else:
                 url += ','.join(['%s' % (ODataPathParser.encode_method_value(value)) for (i, value) in
-                                 enumerate(method_parameters)])
+                                 enumerate(method_parameters) if value is not None])
             url += ")"
         return url
 

office365/runtime/odata/odata_path_parser.py

@@ -62,7 +62,7 @@ def process_response(self, response):
         """
         qry = self.current_query
         result_object = qry.return_type
-        if isinstance(result_object, ClientObjectCollection):
+        if isinstance(result_object, ClientObject):
             result_object.clear()
 
         if response.headers.get('Content-Type', '').lower().split(';')[0] != 'application/json':

office365/runtime/odata/odata_request.py

@@ -19,12 +19,13 @@ def resolve_field_type(type_id_or_name):
         from office365.sharepoint.fields.field_currency import FieldCurrency
         from office365.sharepoint.fields.field_guid import FieldGuid
         from office365.sharepoint.fields.field_lookup import FieldLookup
-        from office365.sharepoint.fields.fieldMultiChoice import FieldMultiChoice
-        from office365.sharepoint.fields.fieldMultiLineText import FieldMultiLineText
+        from office365.sharepoint.fields.field_multi_choice import FieldMultiChoice
+        from office365.sharepoint.fields.field_multi_line_text import FieldMultiLineText
         from office365.sharepoint.fields.field_text import FieldText
         from office365.sharepoint.fields.field_url import FieldUrl
         from office365.sharepoint.fields.field_user import FieldUser
         from office365.sharepoint.taxonomy.taxonomy_field import TaxonomyField
+        from office365.sharepoint.fields.field_date_time import FieldDateTime
         field_known_types = {
             FieldType.Text: FieldText,
             FieldType.Calculated: FieldCalculated,
@@ -36,17 +37,27 @@ def resolve_field_type(type_id_or_name):
             FieldType.URL: FieldUrl,
             FieldType.Guid: FieldGuid,
             FieldType.Currency: FieldCurrency,
-            FieldType.Note: FieldMultiLineText
+            FieldType.Note: FieldMultiLineText,
+            FieldType.DateTime: FieldDateTime
         }
         if isinstance(type_id_or_name, int):
             return field_known_types.get(type_id_or_name, Field)
         else:
             return TaxonomyField if type_id_or_name == "TaxonomyFieldType" else Field
 
     @staticmethod
-    def create_field_from_type(context, field_type):
-        field_type = Field.resolve_field_type(field_type)
-        return field_type(context)
+    def create_field_from_type(context, field_parameters):
+        """
+
+        :type context: ClientContext
+        :type field_parameters: office365.sharepoint.fields.field_creation_information.FieldCreationInformation
+        :return: Field
+        """
+        field_type = Field.resolve_field_type(field_parameters.FieldTypeKind)
+        field = field_type(context)
+        for n, v in field_parameters.to_json().items():
+            field.set_property(n, v)
+        return field
 
     def set_show_in_display_form(self, flag):
         """Sets the value of the ShowInDisplayForm property for this fields.
@@ -85,14 +96,46 @@ def id(self):
         """
         return self.properties.get('Id', None)
 
+    @property
+    def type_as_string(self):
+        """Gets a value that specifies the type of the field..
+
+        :rtype: str or None
+        """
+        return self.properties.get('TypeAsString', None)
+
     @property
     def title(self):
-        """Gets or sets a value that specifies the display name of the field.
+        """Gets a value that specifies the display name of the field.
 
         :rtype: str or None
         """
         return self.properties.get('Title', None)
 
+    @title.setter
+    def title(self, val):
+        """Sets a value that specifies the display name of the field.
+
+        :rtype: str or None
+        """
+        self.set_property("Title", val)
+
+    @property
+    def group(self):
+        """Gets a value that specifies the field group.
+
+        :rtype: str or None
+        """
+        return self.properties.get('Group', None)
+
+    @group.setter
+    def group(self, val):
+        """Sets a value that specifies the field group.
+
+        :rtype: str or None
+        """
+        self.set_property("Group", val)
+
     @property
     def internal_name(self):
         """Gets a value that specifies the field internal name.

office365/sharepoint/fields/addFieldOptions.py renamed to office365/sharepoint/fields/add_field_options.py

@@ -1,5 +1,5 @@
 from office365.runtime.client_value_collection import ClientValueCollection
-from office365.sharepoint.fields.fieldLookupValue import FieldLookupValue
+from office365.sharepoint.fields.field_lookup_value import FieldLookupValue
 
 
 class FieldMultiLookupValue(ClientValueCollection):

office365/sharepoint/fields/field.py

@@ -23,9 +23,20 @@ def add(self, field_create_information):
 
         :type field_create_information: office365.sharepoint.fields.field_creation_information.FieldCreationInformation
         """
-        field = Field.create_field_from_type(self.context, field_create_information.FieldTypeKind)
+        field = Field.create_field_from_type(self.context, field_create_information)
         self.add_child(field)
-        qry = CreateEntityQuery(self, field_create_information, field)
+        qry = CreateEntityQuery(self, field, field)
+        self.context.add_query(qry)
+        return field
+
+    def add_field(self, parameters):
+        """Adds a fields to the fields collection.
+
+        :type parameters: office365.sharepoint.fields.field_creation_information.FieldCreationInformation
+        """
+        field = Field(self.context)
+        self.add_child(field)
+        qry = ServiceOperationQuery(self, "AddField", None, parameters, "parameters", field)
         self.context.add_query(qry)
         return field
 

office365/sharepoint/fields/fieldMultiLookupValue.py

@@ -4,7 +4,7 @@
 class FieldComputed(Field):
 
     @property
-    def enableLookup(self):
+    def enable_lookup(self):
         """
         Specifies whether a lookup field can reference the field (2).