Factory.define is not working!

[IanChok]

if (Meteor.isServer) {
  describe('Workspaces Methods', function () {
    Factory.define('workspace', CollectionWorkSpaces, {
      owner: () => 'ABC',
      participant_ids: () => ['123'],
      invitee_emails: () => []
    });

    beforeEach(function () {
      resetDatabase();
    });

    it('updates invitee email list', function () {
      const document1 = Factory.create('workspace');
      console.log(document1); 
    })
  });
}

//output of document1
{
  _id: '7Qc9PTQpxCesqZS5k',
  owner: '3a6rW9QqnoTpMctCd',
  participant_ids: [],
  invitee_emails: []
}

//expected output:
{
  _id: '7Qc9PTQpxCesqZS5k',
  owner: 'ABC',
  participant_ids: ['123'],
  invitee_emails: []
}

Meteor version 2.5
dburles:factory version 1.1.0

[dburles]

Hey @IanChok there must be something else at play. Can you try to create a reproduction test in the package tests?

1. Fork the repo
2. Write a test case that reproduces the bug
3. Run meteor test-packages ./ to try it out
4. Create a PR with a fix (if possible!)

[IanChok]

Odd, it's working now... I ignored the error, and just continued developing. After a while I came back and now it seems to be working. I have no idea what I did to cause the issue in the first place, nor what I did to fix it 😅 I guess issue resolved

[IanChok]

Actually the issue came back in a different test file. I'll try to create a repro soon if I get some free time!

[IanChok]

@dburles Ah ok, I've discovered that to get Factory.define working, it needs to be put inside the before() function of the mocha framework. In the above example, to get it working it should look like this instead

if (Meteor.isServer) {
  describe('Workspaces Methods', function () {
    before(() => {
             Factory.define('workspace', CollectionWorkSpaces, {
                 owner: () => 'ABC',
                 participant_ids: () => ['123'],
                 invitee_emails: () => []
            });
     })
    beforeEach(function () {
      resetDatabase();
    });

    it('updates invitee email list', function () {
      const document1 = Factory.create('workspace');
      console.log(document1); 
    })
  });
}

Then the output is

//output of document1
{
  _id: '7Qc9PTQpxCesqZS5k',
  owner: 'ABC',
  participant_ids: ['123'],
  invitee_emails: []
}

I'm not sure if Factory.define is intended to be put in a before() function or if that's just the case with the mocha framework. In either case, I'd recommend that this is documented somewhere in the Read.me

[dburles]

Can you recreate the bug in a standalone application and link it here? We still don't know the root cause of the issue.