Skip to content

General suggestions #2

Open
Open
@toddstrader

Description

@toddstrader

This is great, thanks for adding. Some quick suggestions off the top of my head:

A forced retry option would be nice. It seems that --retry will only re-run failing steps, but when I had to make Verilator changes which fixed C++ compilation, verilation hadn't failed so I had to rm -rf work in order to get things to run again.

Running all the cases is a little annoying because the shell will expand * into non-useful things. It appears to do the thing I want when I escape * so maybe just a note in --help about this would be good.

Parallelization of the different steps would be amazing. I'm sure this would be a bit tricky because the verilated Makefiles already -j, but it would be super nice to be able to chew through these different tests on all the cores I have.

It's a little unfortunate that the config is split between this repo and rtlmeter.yml back in the Verilator repo. For instance, some cases are commented out in that YAML, so I'm guessing I should expect them to pass but then it's less easy to locally run all the "good" cases. But I'm guessing just doing cases: "*" would be less idea in terms of CI throughput. So I don't exactly know what to suggest other than mentioning that it's nice to be able to simply run what Verilator's CI is doing myself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions