Skip to content

add .github directory to CNA isFolderEmpty allow list #79551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

chrisweb
Copy link
Contributor

@chrisweb chrisweb commented May 23, 2025

I'm sorry I just now read that you should open a discussion first, I already created a new issue for this as well as a reproduction, let me know if I should go back, close my issue and then open a discussion instead

the suggested feature, is about adding .github to the allowed directories and files list for the CNA "isFolderEmpty" function

fixes: #79550

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label May 23, 2025
Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: f7bcb2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ijjk
Copy link
Member

ijjk commented May 23, 2025

Allow CI Workflow Run

  • approve CI run for commit: f7bcb2f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented May 23, 2025

Allow CI Workflow Run

  • approve CI run for commit: f7bcb2f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNA: add .github to allow list when checking if directory is empty
2 participants