Skip to content

Commit c7fa87e

Browse files
authored
fix error reporting for get_from_source errors (vercel/turborepo#4690)
### Description We never reported issues from get_from_source. This leads to cryptic fatal errors from get_from_source without further details. Now we report the actual issues with show the details.
1 parent 1414ae6 commit c7fa87e

File tree

1 file changed

+8
-4
lines changed
  • crates/turbopack-dev-server/src

1 file changed

+8
-4
lines changed

crates/turbopack-dev-server/src/http.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,13 @@ use turbo_tasks_bytes::Bytes;
1515
use turbo_tasks_fs::{FileContent, FileContentReadRef};
1616
use turbopack_core::{asset::AssetContent, issue::IssueReporterVc, version::VersionedContent};
1717

18-
use crate::source::{
19-
request::SourceRequest,
20-
resolve::{resolve_source_request, ResolveSourceRequestResult},
21-
Body, ContentSourceVc, HeaderListReadRef, ProxyResultReadRef,
18+
use crate::{
19+
handle_issues,
20+
source::{
21+
request::SourceRequest,
22+
resolve::{resolve_source_request, ResolveSourceRequestResult},
23+
Body, ContentSourceVc, HeaderListReadRef, ProxyResultReadRef,
24+
},
2225
};
2326

2427
#[turbo_tasks::value(serialization = "none")]
@@ -75,6 +78,7 @@ pub async fn process_request_with_content_source(
7578
let original_path = request.uri().path().to_string();
7679
let request = http_request_to_source_request(request).await?;
7780
let result = get_from_source(source, TransientInstance::new(request), issue_reporter);
81+
handle_issues(result, &original_path, "get_from_source", issue_reporter).await?;
7882
match &*result.strongly_consistent().await? {
7983
GetFromSourceResult::Static {
8084
content,

0 commit comments

Comments
 (0)