Skip to content

Commit 66ecb87

Browse files
authored
Turbopack: asset ident instead of chunk item ID in CSS (#78018)
This is absolutely useless with numerical ids (prod build with `turbopackMinify: false`): ```css /* 51318 */ .base2-module__zzC_ua__base { color: #ff0200; } /* 29244 */ .base2-scss-module-scss-module__JjfRsa__base { color: #ff0300; } /* 85234 */ .base-module__DNnTeq__base { color: red; } /* 29244 */ .base2-scss-module-scss-module__JjfRsa__base { color: #ff0300; } ```
1 parent 7a134ec commit 66ecb87

File tree

2 files changed

+3
-3
lines changed
  • turbopack/crates/turbopack-css/src/chunk

2 files changed

+3
-3
lines changed

turbopack/crates/turbopack-css/src/chunk/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ impl CssChunk {
8989
&*this.chunking_context.minify_type().await?,
9090
MinifyType::NoMinify
9191
) {
92-
let id = &*css_item.id().await?;
92+
let id = css_item.asset_ident().to_string().await?;
9393
writeln!(body, "/* {} */", id)?;
9494
}
9595

turbopack/crates/turbopack-css/src/chunk/single_item_chunk/chunk.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use turbo_tasks::{ResolvedVc, ValueToString, Vc};
66
use turbo_tasks_fs::{rope::RopeBuilder, File, FileSystemPath};
77
use turbopack_core::{
88
asset::{Asset, AssetContent},
9-
chunk::{Chunk, ChunkItem, ChunkItemExt, ChunkingContext, MinifyType},
9+
chunk::{Chunk, ChunkItem, ChunkingContext, MinifyType},
1010
code_builder::{Code, CodeBuilder},
1111
ident::AssetIdent,
1212
introspect::Introspectable,
@@ -59,7 +59,7 @@ impl SingleItemCssChunk {
5959
&*this.chunking_context.minify_type().await?,
6060
MinifyType::NoMinify
6161
) {
62-
let id = this.item.id().await?;
62+
let id = this.item.asset_ident().to_string().await?;
6363
writeln!(code, "/* {} */", id)?;
6464
}
6565
let content = this.item.content().await?;

0 commit comments

Comments
 (0)