Skip to content

Commit af79b04

Browse files
authored
Update some development-only dependencies (#147)
* Remove unused Rails 5.1 Appraisals Seems like I forgot to remove these when I stopped testing with these versions in CI * Update rspec and rspec-rails to latest versions * Update rake to 13.0 * Update phare to 1.0.1 * Verify code style in GitHub actions
1 parent 9eb0951 commit af79b04

File tree

5 files changed

+15
-48
lines changed

5 files changed

+15
-48
lines changed

.github/workflows/ruby.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,14 @@ jobs:
4444
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
4545
- name: Run tests
4646
run: bundle exec rake
47+
code-style:
48+
runs-on: ubuntu-20.04
49+
steps:
50+
- uses: actions/checkout@v2
51+
- name: Set up Ruby
52+
uses: ruby/setup-ruby@v1
53+
with:
54+
ruby-version: 2.7
55+
bundler-cache: true
56+
- name: Verify code style
57+
run: bundle exec phare

Appraisals

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
appraise 'rails-5-1 pundit-1' do
2-
gem "rails", "5.1.7"
3-
gem 'jsonapi-resources', '~> 0.9.0'
4-
gem 'pundit', '~> 1.0'
5-
group :development, :test do
6-
gem 'sqlite3', '~> 1.3.13'
7-
end
8-
end
9-
101
appraise 'rails-5-2 pundit-1' do
112
gem 'rails', '5.2.4.4'
123
gem 'jsonapi-resources', '~> 0.9.0'
@@ -25,15 +16,6 @@ appraise 'rails-6-0 pundit-1' do
2516
end
2617
end
2718

28-
appraise 'rails-5-1 pundit-2' do
29-
gem 'rails', '5.1.7'
30-
gem 'jsonapi-resources', '~> 0.9.0'
31-
gem 'pundit', '~> 2.0'
32-
group :development, :test do
33-
gem 'sqlite3', '~> 1.3.13'
34-
end
35-
end
36-
3719
appraise 'rails-5-2 pundit-2' do
3820
gem 'rails', '5.2.4.4'
3921
gem 'jsonapi-resources', '~> 0.9.0'

gemfiles/rails_5_1_pundit_1.gemfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

gemfiles/rails_5_1_pundit_2.gemfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

jsonapi-authorization.gemspec

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ Gem::Specification.new do |spec|
2222

2323
spec.add_development_dependency "appraisal"
2424
spec.add_development_dependency "bundler", ">= 1.11"
25-
spec.add_development_dependency "rake", "~> 12.0"
26-
spec.add_development_dependency "rspec", "~> 3.8"
27-
spec.add_development_dependency "rspec-rails", "~> 3.8"
25+
spec.add_development_dependency "rake", "~> 13.0"
26+
spec.add_development_dependency "rspec", "~> 3.11"
27+
spec.add_development_dependency "rspec-rails", "~> 5.1"
2828
spec.add_development_dependency "pry"
2929
spec.add_development_dependency "pry-byebug"
3030
spec.add_development_dependency "pry-doc"
3131
spec.add_development_dependency "pry-rails"
3232
spec.add_development_dependency "rubocop", "~> 0.36.0"
33-
spec.add_development_dependency "phare", "~> 0.7.1"
33+
spec.add_development_dependency "phare", "~> 1.0.1"
3434
spec.add_development_dependency "sqlite3", "~> 1.3"
3535
end

0 commit comments

Comments
 (0)