Testing Requirements for Different Changes

[5Dev24]

Currently, I have 4 changes (to be made into 4 PRs) for the Redis sink, templating, and S3.

1. Support for Redis Sentinel in Redis sink
   • Support Redis Sentinel for redis source #13535 though this is for sink, not source
2. Support for using ZADD command in Redis sink
3. Support for using strftime items in UnsignedIntTemplate
   • Would ideally be SignedIntTemplate since ZADD supports negative values, but that type doesn't exist and this is good enough for now
4. Log for s3_common sinks when putting an object
   • Logs bucket and key for later use by using internal_logs source
   • add internal log event for S3 sink #22994

While I have locally tested these changes, but want to know what testing you'd like to see for each?

Mainly wondering for the Redis Sentinel and ZADD testing since the template change can be covered by unit testing. These aren't new sinks, but add new capabilities to the existing sink.

I'm also fine waiting until I make the PRs to discuss each separately. Currently waiting on approval before contributing upstream, so wanted to ask about this while waiting and to save y'all time reviewing.

[pront]

Hi @5Dev24, for changes to integrations, we want to see unit tests or new integration tests.
We also encourage splitting work into the smallest possible PRs in order to accelerate reviews and allow for easy reverts in case of a regression.