Skip to content

Commit a1defec

Browse files
authored
refactor: Move from kaptan to ConfigReader (#397)
ConfigReader is typed, doctest'd, 200 lines of code. The maintainer of kaptan gets along well us well but has been unresponsive for years.
2 parents a88b98e + d29fa6d commit a1defec

File tree

10 files changed

+286
-104
lines changed

10 files changed

+286
-104
lines changed

CHANGES

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ $ pipx install --suffix=@next 'vcspull' --pip-args '\--pre' --force
2323

2424
- Move test fixtures over to libvcs's pytest plugin (#398)
2525
- Move conftest.py to root directory (#399)
26+
- Add `ConfigReader`: Our clean, typed parser for raw strings and files (#397)
27+
28+
This is our shiny, new, 200-line, doctested and typed parser that replaces `kaptan`.
29+
30+
### Packaging
31+
32+
- Drop kaptan dependency (#397)
2633

2734
## vcspull v1.13.0 (2022-09-25)
2835

docs/conf.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,13 @@
9898
autoclass_content = "both"
9999
autodoc_member_order = "bysource"
100100
toc_object_entries_show_parents = "hide"
101+
autodoc_default_options = {
102+
"undoc-members": True,
103+
"members": True,
104+
"private-members": True,
105+
"show-inheritance": True,
106+
"member-order": "bysource",
107+
}
101108

102109
# sphinx-autodoc-typehints
103110
autodoc_typehints = "description" # show type hints in doc body instead of signature

poetry.lock

Lines changed: 42 additions & 52 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ vcspull = 'vcspull:cli.cli'
6060
[tool.poetry.dependencies]
6161
python = "^3.9"
6262
click = "~8"
63-
kaptan = "*"
6463
libvcs = "~0.17.0"
6564
colorama = ">=0.3.9"
6665

@@ -134,12 +133,6 @@ lint = [
134133
python_version = 3.9
135134
warn_unused_configs = true
136135

137-
[[tool.mypy.overrides]]
138-
module = [
139-
"kaptan.*",
140-
]
141-
ignore_missing_imports = true
142-
143136
[tool.coverage.run]
144137
branch = true
145138
parallel = true

src/vcspull/_internal/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)