refactor: Centralize save_config_yaml function (Phase 3)

- Add save_config_yaml to vcspull.config module using ConfigReader._dump
- Remove duplicate implementations from cli/add.py and cli/add_from_fs.py
- Update imports to use the centralized function
- Remove duplicate from test helpers
- Follows DRY principle and provides consistent YAML formatting

Author: tony

src/vcspull/cli/add.py

@@ -11,6 +11,7 @@
 from vcspull.config import (
     expand_dir,
     find_home_config_files,
+    save_config_yaml,
 )
 
 if t.TYPE_CHECKING:
@@ -251,17 +252,7 @@ def add_repo(
     raw_config[actual_base_dir_key][repo_name] = repo_url
 
     try:
-        # save_config_yaml(config_file_path, raw_config) # Original call to local/helper
-        # The main application code should use a robust save mechanism.
-        # For now, directly writing, similar to the old save_config_yaml.
-        with config_file_path.open("w", encoding="utf-8") as f:
-            yaml.dump(
-                raw_config,
-                f,
-                sort_keys=False,
-                indent=2,
-                default_flow_style=False,
-            )
+        save_config_yaml(config_file_path, raw_config)
         log.info(
             f"Successfully added '{repo_name}' ({repo_url}) to {config_file_path} "
             f"under '{actual_base_dir_key}'.",

src/vcspull/cli/add_from_fs.py

@@ -13,6 +13,7 @@
 from vcspull.config import (  # Assuming these are useful
     expand_dir,
     find_home_config_files,
+    save_config_yaml,
 )
 
 if t.TYPE_CHECKING:
@@ -38,12 +39,6 @@ def get_git_origin_url(repo_path: pathlib.Path) -> str | None:
         return None
 
 
-def save_config_yaml(config_file_path: pathlib.Path, data: dict[t.Any, t.Any]) -> None:
-    """Save a dictionary to a YAML file."""
-    with config_file_path.open("w", encoding="utf-8") as f:
-        yaml.dump(data, f, sort_keys=False, indent=2, default_flow_style=False)
-
-
 def create_add_from_fs_subparser(parser: argparse.ArgumentParser) -> None:
     """Configure :py:class:`argparse.ArgumentParser` for ``vcspull add-from-fs``."""
     parser.add_argument(

src/vcspull/config.py

@@ -424,3 +424,21 @@ def is_config_file(
         extensions = [".yml", ".yaml", ".json"]
     extensions = [extensions] if isinstance(extensions, str) else extensions
     return any(filename.endswith(e) for e in extensions)
+
+
+def save_config_yaml(config_file_path: pathlib.Path, data: dict[t.Any, t.Any]) -> None:
+    """Save configuration data to a YAML file.
+
+    Parameters
+    ----------
+    config_file_path : pathlib.Path
+        Path to the configuration file to write
+    data : dict
+        Configuration data to save
+    """
+    yaml_content = ConfigReader._dump(
+        fmt="yaml",
+        content=data,
+        indent=2,
+    )
+    config_file_path.write_text(yaml_content, encoding="utf-8")

tests/cli/test_add_from_fs.py

@@ -10,8 +10,8 @@
 import pytest
 import yaml
 
-from tests.helpers import save_config_yaml
 from vcspull.cli.add_from_fs import add_from_filesystem, get_git_origin_url
+from vcspull.config import save_config_yaml
 
 if t.TYPE_CHECKING:
     from _pytest.logging import LogCaptureFixture

tests/helpers.py

@@ -63,9 +63,3 @@ def load_raw(data: str, fmt: t.Literal["yaml", "json"]) -> dict[str, t.Any]:
     return ConfigReader._load(fmt=fmt, content=data)
 
 
-def save_config_yaml(config_file_path: pathlib.Path, data: dict[t.Any, t.Any]) -> None:
-    """Save a dictionary to a YAML file."""
-    import yaml
-
-    yaml_content = yaml.dump(data, sort_keys=False, indent=2, default_flow_style=False)
-    write_config(config_file_path, yaml_content)