Revert "chore: Use create_repo_legacy"

This reverts commit 80c0ea4.

Author: tony

README.md

@@ -25,10 +25,10 @@ Create a [Repo](https://libvcs.git-pull.com/api.html#creating-a-repo-object) obj
 to inspect / checkout / update:
 
 ```python
->>> from libvcs.shortcuts import create_repo_from_pip_url, create_repo_legacy
+>>> from libvcs.shortcuts import create_repo_from_pip_url, create_repo
 
 # repo is an object representation of a vcs repository.
->>> r = create_repo_legacy(url='https://www.github.com/vcs-python/libtmux',
+>>> r = create_repo(url='https://www.github.com/vcs-python/libtmux',
 ...                 vcs='git',
 ...                 repo_dir='/tmp/libtmux')
 

libvcs/shortcuts.py

@@ -98,7 +98,7 @@ def create_repo_legacy(
     --------
     >>> from libvcs.shortcuts import create_repo_legacy
     >>>
-    >>> r = create_repo_legacy(
+    >>> r = create_repo(
     ...     url='https://www.github.com/you/myrepo',
     ...     vcs='git',
     ...     repo_dir='/tmp/myrepo'

tests/test_base.py

@@ -2,13 +2,11 @@
 import pathlib
 
 from libvcs.base import BaseRepo, convert_pip_url
-from libvcs.shortcuts import create_repo_legacy
+from libvcs.shortcuts import create_repo
 
 
 def test_repr():
-    repo = create_repo_legacy(
-        url="file://path/to/myrepo", repo_dir="/hello/", vcs="git"
-    )
+    repo = create_repo(url="file://path/to/myrepo", repo_dir="/hello/", vcs="git")
 
     str_repo = str(repo)
     assert "GitRepo" in str_repo

tests/test_hg.py

@@ -5,7 +5,7 @@
 
 import pytest
 
-from libvcs.shortcuts import create_repo_from_pip_url, create_repo_legacy
+from libvcs.shortcuts import create_repo, create_repo_from_pip_url
 from libvcs.util import run, which
 
 if not which("hg"):
@@ -88,7 +88,7 @@ def test_vulnerability_2022_03_12_command_injection(
     random_dir = tmp_path / "random"
     random_dir.mkdir()
     monkeypatch.chdir(str(random_dir))
-    mercurial_repo = create_repo_legacy(
+    mercurial_repo = create_repo(
         url="--config=alias.clone=!touch ./HELLO", vcs="hg", repo_dir="./"
     )
     with pytest.raises(Exception):

tests/test_shortcuts.py

@@ -4,7 +4,7 @@
 
 from libvcs import GitRepo, MercurialRepo, SubversionRepo
 from libvcs.exc import InvalidPipURL, InvalidVCS
-from libvcs.shortcuts import create_repo_from_pip_url, create_repo_legacy
+from libvcs.shortcuts import create_repo, create_repo_from_pip_url
 
 
 @pytest.mark.parametrize(
@@ -67,15 +67,13 @@ def test_create_repo_from_pip_url(
         ),
     ],
 )
-def test_create_repo_legacy(
-    tmp_path: pathlib.Path, repo_dict, repo_class, raises_exception
-):
+def test_create_repo(tmp_path: pathlib.Path, repo_dict, repo_class, raises_exception):
     # add parent_dir via fixture
     repo_dict["repo_dir"] = tmp_path / "repo_name"
 
     if raises_exception:
         with pytest.raises(raises_exception):
-            create_repo_legacy(**repo_dict)
+            create_repo(**repo_dict)
     else:
-        repo = create_repo_legacy(**repo_dict)
+        repo = create_repo(**repo_dict)
         assert isinstance(repo, repo_class)