refactor(BaseRepo): Remove __slots__ and __dict__ magic (#268)

Passing 'remotes' into a repo object could override the new GitRepo.remotes
method.

Author: tony

CHANGES

@@ -10,6 +10,11 @@ Generally speaking, refactor / magic is in the process of being stripped
 out in the next few releases. The API is subject to change significantly
 in pre-1.0 builds.
 
+- :class:`libvcs.base.BaseRepo`: 
+  
+  - no longer sets ``**kwargs`` to dictionary on the object
+  - remove ``__slot__`` and rename ``name`` attribute to ``repo_name``
+
 libvcs 0.4.3 (2020-08-01)
 -------------------------
 - [bug] :func:`libvcs.git.extract_status()` Fix issue capturing branch names

libvcs/base.py

@@ -31,8 +31,6 @@ class BaseRepo(RepoLoggingAdapter, object):
     #: vcs app name, e.g. 'git'
     bin_name = ''
 
-    __slots__ = ['name']
-
     def __init__(self, url, repo_dir, progress_callback=None, *args, **kwargs):
         """
         :param callback: Retrieve live progress from ``sys.stderr`` (useful for
@@ -44,11 +42,10 @@ def progress_cb(output, timestamp):
                 create_repo(..., progress_callback=progress_cb)
         :type callback: func
         """
-        self.__dict__.update(kwargs)
         self.progress_callback = progress_callback
         self.url = url
         self.parent_dir = os.path.dirname(repo_dir)
-        self.name = os.path.basename(os.path.normpath(repo_dir))
+        self.repo_name = os.path.basename(os.path.normpath(repo_dir))
         self.path = repo_dir
 
         # Register more schemes with urlparse for various version control
@@ -118,7 +115,8 @@ def check_destination(self, *args, **kwargs):
 
         if not os.path.exists(self.path):
             self.debug(
-                'Repo directory for %s does not exist @ %s' % (self.name, self.path)
+                'Repo directory for %s does not exist @ %s'
+                % (self.repo_name, self.path)
             )
             mkdir_p(self.path)
 
@@ -142,4 +140,4 @@ def get_url_and_revision_from_pip_url(cls, pip_url):
         return url, rev
 
     def __repr__(self):
-        return "<{} {}>".format(self.__class__.__name__, self.name)
+        return "<{} {}>".format(self.__class__.__name__, self.repo_name)

libvcs/svn.py

@@ -51,6 +51,8 @@ def __init__(self, url, **kwargs):
         """
         if 'svn_trust_cert' not in kwargs:
             self.svn_trust_cert = False
+
+        self.rev = kwargs.get('rev')
         BaseRepo.__init__(self, url, **kwargs)
 
     def _user_pw_args(self):

libvcs/util.py

@@ -89,8 +89,8 @@ class RepoLoggingAdapter(logging.LoggerAdapter):
 
     Any class that subclasses this will have its class attributes for:
 
-        - :attr:`~.bin_name` -> ``repo_vcs``
-        - :attr:`~.name` -> ``repo_name``
+    - :attr:`~.bin_name` -> ``repo_vcs``
+    - :attr:`~.repo_name` -> ``repo_name``
 
     Added to a dictionary of context information in :py:meth:`
     logging.LoggerAdapter.process()` to be made use of when the user of this
@@ -106,7 +106,7 @@ def process(self, msg, kwargs):
         """Add additional context information for loggers."""
         prefixed_dict = {}
         prefixed_dict['repo_vcs'] = self.bin_name
-        prefixed_dict['repo_name'] = self.name
+        prefixed_dict['repo_name'] = self.repo_name
 
         kwargs["extra"] = prefixed_dict
 

tests/test_hg.py

@@ -40,7 +40,7 @@ def test_repo_mercurial(tmpdir, parentdir, hg_remote):
         }
     )
 
-    run(['hg', 'init', mercurial_repo.name], cwd=str(tmpdir))
+    run(['hg', 'init', mercurial_repo.repo_name], cwd=str(tmpdir))
 
     mercurial_repo.update_repo()