Skip to content

Commit 6b26da4

Browse files
committed
BaseRepo: Remove __slot__ and don't use reserved object attribute
1 parent 397dc16 commit 6b26da4

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

libvcs/base.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ class BaseRepo(RepoLoggingAdapter, object):
3131
#: vcs app name, e.g. 'git'
3232
bin_name = ''
3333

34-
__slots__ = ['name']
35-
3634
def __init__(self, url, repo_dir, progress_callback=None, *args, **kwargs):
3735
"""
3836
:param callback: Retrieve live progress from ``sys.stderr`` (useful for
@@ -47,7 +45,7 @@ def progress_cb(output, timestamp):
4745
self.progress_callback = progress_callback
4846
self.url = url
4947
self.parent_dir = os.path.dirname(repo_dir)
50-
self.name = os.path.basename(os.path.normpath(repo_dir))
48+
self.repo_name = os.path.basename(os.path.normpath(repo_dir))
5149
self.path = repo_dir
5250

5351
# Register more schemes with urlparse for various version control
@@ -117,7 +115,8 @@ def check_destination(self, *args, **kwargs):
117115

118116
if not os.path.exists(self.path):
119117
self.debug(
120-
'Repo directory for %s does not exist @ %s' % (self.name, self.path)
118+
'Repo directory for %s does not exist @ %s'
119+
% (self.repo_name, self.path)
121120
)
122121
mkdir_p(self.path)
123122

@@ -141,4 +140,4 @@ def get_url_and_revision_from_pip_url(cls, pip_url):
141140
return url, rev
142141

143142
def __repr__(self):
144-
return "<{} {}>".format(self.__class__.__name__, self.name)
143+
return "<{} {}>".format(self.__class__.__name__, self.repo_name)

0 commit comments

Comments
 (0)