refactor: Rename check_destination -> ensure_dir

Author: tony

libvcs/base.py

@@ -127,7 +127,7 @@ def run(
             cwd=cwd,
         )
 
-    def check_destination(self, *args, **kwargs):
+    def ensure_dir(self, *args, **kwargs):
         """Assure destination path exists. If not, create directories."""
         if os.path.exists(self.path):
             return True

libvcs/git.py

@@ -167,7 +167,7 @@ def get_revision(self):
 
     def obtain(self):
         """Retrieve the repository, clone if doesn't exist."""
-        self.check_destination()
+        self.ensure_dir()
 
         url = self.url
 
@@ -188,7 +188,7 @@ def obtain(self):
         self.run(cmd, log_in_real_time=True)
 
     def update_repo(self):
-        self.check_destination()
+        self.ensure_dir()
 
         if not os.path.isdir(os.path.join(self.path, '.git')):
             self.obtain()

libvcs/hg.py

@@ -25,7 +25,7 @@ def __init__(self, url, repo_dir, **kwargs):
         BaseRepo.__init__(self, url, repo_dir, **kwargs)
 
     def obtain(self):
-        self.check_destination()
+        self.ensure_dir()
 
         self.run(['clone', '--noupdate', '-q', self.url, self.path])
         self.run(['update', '-q'])
@@ -34,7 +34,7 @@ def get_revision(self):
         return self.run(['parents', '--template={rev}'])
 
     def update_repo(self):
-        self.check_destination()
+        self.ensure_dir()
         if not os.path.isdir(os.path.join(self.path, '.hg')):
             self.obtain()
             self.update_repo()

libvcs/svn.py

@@ -68,7 +68,7 @@ def _user_pw_args(self):
         return args
 
     def obtain(self, quiet=None):
-        self.check_destination()
+        self.ensure_dir()
 
         url, rev = self.url, self.rev
 
@@ -124,7 +124,7 @@ def get_revision(self, location=None):
         return revision
 
     def update_repo(self, dest=None):
-        self.check_destination()
+        self.ensure_dir()
         if os.path.isdir(os.path.join(self.path, '.svn')):
             dest = self.path if not dest else dest
 

tests/test_base.py

@@ -24,12 +24,12 @@ def test_repr_base():
     assert '<BaseRepo hello>' == str_repo
 
 
-def test_check_destination_creates_parent_if_not_exist(tmpdir):
+def test_ensure_dir_creates_parent_if_not_exist(tmpdir):
     parentdir = tmpdir.join('parentdir')  # doesn't exist yet
     repo_dir = parentdir.join('myrepo')
     repo = BaseRepo(url='file://path/to/myrepo', repo_dir=str(repo_dir))
 
-    repo.check_destination()
+    repo.ensure_dir()
     assert parentdir.check()