Go-Redis replacement parameters in latest valkey-go

[royatanu94]

Hi All,
When establishing a Redis connection using go-redis, we configure it through redis.UniversalOptions with the parameters listed below. Could you help identify the corresponding parameters available in valkey-go?
rcOptions = &redis.UniversalOptions{ Addrs: conf.SentinelAddresses, SentinelUsername: conf.SentinelUsername, SentinelPassword: conf.SentinelPassword, MasterName: conf.MasterName, Username: conf.Username, Password: conf.Password, DB: conf.DB, TLSConfig: tlsConfig, DialTimeout: time.Duration(conf.DialTimeout) * time.Millisecond, ReadTimeout: time.Duration(conf.ReadTimeout) * time.Millisecond, WriteTimeout: time.Duration(conf.WriteTimeout) * time.Millisecond, PoolTimeout: conf.PoolTimeout, PoolSize: conf.PoolSize, } } else if len(conf.ClusterAddresses) > 0 { logger.Infow("connecting to redis", "cluster", true, "addr", conf.ClusterAddresses) rcOptions = &redis.UniversalOptions{ Addrs: conf.ClusterAddresses, Username: conf.Username, Password: conf.Password, DB: conf.DB, TLSConfig: tlsConfig, MaxRedirects: conf.GetMaxRedirects(), PoolTimeout: conf.PoolTimeout, PoolSize: conf.PoolSize, } } else { logger.Infow("connecting to redis", "simple", true, "addr", conf.Address) rcOptions = &redis.UniversalOptions{ Addrs: []string{conf.Address}, Username: conf.Username, Password: conf.Password, DB: conf.DB, TLSConfig: tlsConfig, PoolTimeout: conf.PoolTimeout, PoolSize: conf.PoolSize, } }

TIA

[royatanu94]

@rueian Any help is appreciated

[rueian]

Hi @royatanu94,

You can try these

Sentinel

	rueidis.ClientOption{
		InitAddress: conf.SentinelAddresses,
		Sentinel: rueidis.SentinelOption{
			MasterSet: conf.MasterName,
			Username:  conf.SentinelUsername,
			Password:  conf.SentinelPassword,
		},
		Username:     conf.Username,
		Password:     conf.Password,
		SelectDB:     conf.DB,
		TLSConfig:    tlsConfig,
		Dialer:           net.Dialer{Timeout: time.Duration(conf.DialTimeout) * time.Millisecond},
		ConnWriteTimeout: time.Duration(conf.WriteTimeout) * time.Millisecond,
		BlockingPoolSize: conf.PoolSize,
	}

Cluster

	rueidis.ClientOption{
		InitAddress:      conf.ClusterAddresses,
		Username:         conf.Username,
		Password:         conf.Password,
		SelectDB:         conf.DB,
		TLSConfig:        tlsConfig,
		Dialer:           net.Dialer{Timeout: time.Duration(conf.DialTimeout) * time.Millisecond},
		ConnWriteTimeout: time.Duration(conf.WriteTimeout) * time.Millisecond,
		BlockingPoolSize: conf.PoolSize,
	}

Standalone

	rueidis.ClientOption{
		InitAddress:      []string{conf.Address},
		Username:         conf.Username,
		Password:         conf.Password,
		SelectDB:         conf.DB,
		TLSConfig:        tlsConfig,
		Dialer:           net.Dialer{Timeout: time.Duration(conf.DialTimeout) * time.Millisecond},
		ConnWriteTimeout: time.Duration(conf.WriteTimeout) * time.Millisecond,
		BlockingPoolSize: conf.PoolSize,
	}

[royatanu94]

@rueian
Looks like we don't have exact params for

		PoolTimeout:      conf.PoolTimeout,
		ReadTimeout:      time.Duration(conf.ReadTimeout) * time.Millisecond,
		
		But for other param we have
		DB:               SelectDB
		DialTimeout:      Dialer
		WriteTimeout:     ConnWriteTimeout
		PoolSize:         BlockingPoolSize
		
		https://github.com/valkey-io/valkey-go/blob/main/valkey.go#L71

[rueian]

Yes, we don't have global PoolTimeout and ReadTimeout, but you can set different timeouts on each Redis request with their context.