Fix VALKEYCLI_AUTH env variable fallback to REDISCLI_AUTH mistake (#2038)

HiranmoyChowdhury · web-flow · commit 4571886b4178 · 2025-05-05T11:20:37.000+02:00
Fix flipped-logic mistake introduced in #1995. Signed-off-by: Hiranmoy Das Chowdhury <hiranmoy.das70@gmail.com>
diff --git a/src/valkey-cli.c b/src/valkey-cli.c
@@ -2908,7 +2908,7 @@ static int parseOptions(int argc, char **argv) {
 static void parseEnv(void) {
     /* Set auth from env, but do not overwrite CLI arguments if passed */
     char *auth = getenv(CLI_AUTH_ENV);
-    if (auth != NULL) {
+    if (auth == NULL) {
         auth = getenv(OLD_CLI_AUTH_ENV);
     }
     if (auth != NULL && config.conn_info.auth == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -2908,7 +2908,7 @@ static int parseOptions(int argc, char **argv) {`
`2908`	`2908`	`static void parseEnv(void) {`
`2909`	`2909`	`/* Set auth from env, but do not overwrite CLI arguments if passed */`
`2910`	`2910`	`char *auth = getenv(CLI_AUTH_ENV);`
`2911`		`- if (auth != NULL) {`
	`2911`	`+ if (auth == NULL) {`
`2912`	`2912`	`auth = getenv(OLD_CLI_AUTH_ENV);`
`2913`	`2913`	`}`
`2914`	`2914`	`if (auth != NULL && config.conn_info.auth == NULL) {`