Skip to content

There is no opentelemetry-instrumentation-valkey #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PabloReszczynski opened this issue Apr 28, 2025 · 3 comments
Open

There is no opentelemetry-instrumentation-valkey #190

PabloReszczynski opened this issue Apr 28, 2025 · 3 comments

Comments

@PabloReszczynski
Copy link

On the Opentelemetry section on the documentation, it mentions installing opentelemetry-instrumentation-valkey, but only opentelemetry-instrumentation-redis exists, which is only compatible with redis.
Was this done by mistake searching–and–replacing on the docs after the fork was done?
What do you think would be the effort on forking opentelemetry-instrumentation-redis as well?

@amirreza8002
Copy link
Contributor

amirreza8002 commented Apr 29, 2025

hi
are you sure that package doesn't work with valkey?
redis packages usually work with valkey

about the second question, i'd first open an issue or discussion in the repo
https://github.com/open-telemetry/opentelemetry-python-contrib
maybe they'd be willing to add a valkey version
if not, i don't think it'd be very hard to fork it, since it is a small package

@PabloReszczynski
Copy link
Author

I checked the source code of the repo, and it explicitly imports the redis package. This is because the package instruments the redis library, not the connection to the protocol.

@amirreza8002
Copy link
Contributor

it's probably still usable
since you can connect to valkey using redis-py
tho it's a dependency that i wouldn't add

I'd try discussing valkey support with the maintainers of that package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants