fix releases demo tests

Author: manolo

scripts/pit/its/releases.js

@@ -1,5 +1,5 @@
 const { expect} = require('@playwright/test');
-const {log, args, createPage, closePage, takeScreenshot, waitForServerReady} = require('./test-utils');
+const {log, args, createPage, closePage, takeScreenshot, waitForServerReady, dismissDevmode} = require('./test-utils');
 
 (async () => {
     const arg = args();
@@ -10,37 +10,36 @@ const {log, args, createPage, closePage, takeScreenshot, waitForServerReady} = r
 
     await page.locator('html').first().innerHTML();
     await takeScreenshot(page, __filename, 'view1-loaded');
+
+    if (await dismissDevmode(page)) {
+        await takeScreenshot(page, __filename, `dev-mode-indicator-closed`);
+    }
+
     await expect(page.getByText('Pre-releases per version').first()).toBeVisible();
 
     await page.getByText('by release count').click();
 
     await takeScreenshot(page, __filename, 'view3-loaded');
     await expect(page.getByText('Releases per version').first()).toBeVisible();
 
+    const [major, minor] = arg.version.split('.');
+    const labelRegex = new RegExp(`${major}\\.${minor}, `);
+    await page.getByLabel(labelRegex).click();
 
-    if (arg.version !== 'current' ) {
-        const [major, minor] = arg.version.split('.');
-        const labelRegex = new RegExp(`${major}\\.${minor}, `);
-        await page.getByLabel(labelRegex).click();
-
-        await takeScreenshot(page, __filename, `element-${labelRegex}-clicked`);
-        const selector = `path.highcharts-point[aria-label*="${arg.version}"]`
-        await expect(page.getByLabel('Interactive chart').locator(selector)).toBeVisible();
-        await takeScreenshot(page, __filename, `interactive-chart-${arg.version}-loaded`);
-
-        if (arg.mode == 'dev') {
-            try {
-                await page.getByText('Dismiss').click({timeout: 500});
-                await takeScreenshot(page, __filename, `dev-mode-indicator-closed`);
-            } catch (e) {
-                log('No dev mode indicator');
-            }
-        }
+    await takeScreenshot(page, __filename, `element-${labelRegex}-clicked`);
+    let selector = `path.highcharts-point[aria-label*="${arg.version}"]`
+    await expect(page.getByLabel('Interactive chart').locator(selector)).toBeVisible();
+    await takeScreenshot(page, __filename, `interactive-chart-${arg.version}-loaded`);
 
+    if (await page.getByText(arg.version).first().isEnabled()) {
+        await page.getByText(arg.version).first().click();
+    } else if (await page.locator(`${arg.version}, 1.`).isEnabled()) {
+        await page.locator(`${arg.version}, 1.`).isEnabled();
+    } else if (await page.locator(selector).first().isEnabled()) {
         await page.locator(selector).first().click();
-        await expect(page.getByRole('heading', { name: `Release Notes for ${arg.version}` })).toBeVisible();
-        await takeScreenshot(page, __filename, `release-notes-${arg.version}-loaded`);
     }
+    await expect(page.getByRole('heading', { name: `Release Notes for ${arg.version}` })).toBeVisible();
+    await takeScreenshot(page, __filename, `release-notes-${arg.version}-loaded`);
 
     log(JSON.stringify(arg));
     await closePage(page);

scripts/pit/its/test-utils.js

@@ -159,7 +159,9 @@ async function dismissDevmode(page) {
   }
   if (await dismiss.count()) {
     dismiss.click()
+    return true;
   }
+  return false;
 }
 
 module.exports = {

scripts/pit/lib/lib-validate.sh

@@ -114,7 +114,7 @@ runValidations() {
   fi
 
   # 12
-  [ -z "$TEST" ] && bold "----> The version $version of '$name' app was successfully built and tested in $mode mode."
+  [ -z "$TEST" ] && bold "----> The version $version of '$name' app was successfully built and tested in $mode mode." && printnl
   [ -n "$TEST" ] || (killAll && sleep 5)
 
   # 13