Skip to content

Commit 5fcdab7

Browse files
committed
remove redundant parameters that can be done by using CC_TESTS env var
1 parent b3e5f58 commit 5fcdab7

File tree

3 files changed

+1
-23
lines changed

3 files changed

+1
-23
lines changed

README.md

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,3 @@
1-
# [Platform-In-Test Script]
2-
3-
# How To Use
4-
5-
```
6-
./scripts/pit/run.sh --help
7-
```
8-
9-
```
101
Use: ./scripts/pit/run.sh with the next options:
112

123
--version=string Vaadin version to test, if not given it only tests current stable, otherwise it runs tests against current stable and then against given version.
@@ -24,8 +15,6 @@ Use: ./scripts/pit/run.sh with the next options:
2415
--skip-dev Skip dev-mode validations
2516
--skip-clean Do not clean maven cache
2617
--skip-helm Do not re-install control-center with helm and continue running tests, implies (--offline, --keep-cc)
27-
--skip-setup Like --skip-helm but also do not run first playwright setup test, implies --skip-build --skip-helm
28-
--skip-apps Like --skip-setup but also do not run playwright install apps test, implies --skip-build --skip-setup
2918
--skip-pw Do not run playwright tests
3019
--cluster=name Run tests in an existing k8s cluster
3120
--vendor=name Use a specific cluster vendor to run control-center tests options: [dd, kind, do] (default: kind)
@@ -117,8 +106,4 @@ Use: ./scripts/pit/run.sh with the next options:
117106
· designer-tutorial
118107
· walking-skeleton:v24.7-hybrid
119108
· releases-graph
120-
· expo-flow
121-
```
122-
123-
124-
109+
· expo-flow

scripts/pit/lib/lib-args.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ Use: $0 with the next options:
2222
--skip-dev Skip dev-mode validations
2323
--skip-clean Do not clean maven cache
2424
--skip-helm Do not re-install control-center with helm and continue running tests, implies (--offline, --keep-cc)
25-
--skip-setup Like --skip-helm but also do not run first playwright setup test, implies --skip-build --skip-helm
26-
--skip-apps Like --skip-setup but also do not run playwright install apps test, implies --skip-build --skip-setup
2725
--skip-pw Do not run playwright tests
2826
--cluster=name Run tests in an existing k8s cluster
2927
--vendor=name Use a specific cluster vendor to run control-center tests options: [dd, kind, do] (default: kind)
@@ -95,8 +93,6 @@ checkArgs() {
9593
--keep-apps) KEEPAPPS=true;;
9694
--skip-build) SKIPBUILD=true;;
9795
--skip-helm) OFFLINE=true; KEEPCC=true; SKIPHELM=true ;;
98-
--skip-setup) OFFLINE=true; KEEPCC=true; SKIPHELM=true; SKIPBUILD=true; SKIPSETUP=true;;
99-
--skip-apps) OFFLINE=true; KEEPCC=true; SKIPHELM=true; SKIPSETUP=true; SKIPBUILD=true; SKIPAPPS=true ;;
10096
--pnpm) PNPM="-Dpnpm.enable=true";;
10197
--vite) VITE=true;;
10298
--list*)

scripts/pit/lib/lib-k8s-cc.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,6 @@ runPwTests() {
261261
[ "$2" = local -a "$VENDOR" = do ] && R=$DO_REG_URL && S="--secret=$DO_REGST"
262262

263263
for f in $CC_TESTS; do
264-
[ -n "$SKIPSETUP" -a `basename $f` = "cc-setup.js" ] && continue
265-
[ -n "$SKIPAPPS" -a `basename $f` = "cc-install-apps.js" ] && continue
266-
[ -n "$KEEPAPPS" -a `basename $f` = "cc-remove-apps.js" ] && continue
267264
[ "$CLUSTER" == "docker-desktop" ] || stopForwardIngress && forwardIngress $CC_NS || return 1
268265
runPlaywrightTests "$PIT_SCR_FOLDER/its/$f" "" "$T" "control-center" \
269266
--url=https://$CC_CONTROL --login=$CC_EMAIL --version=$CCVERSION \

0 commit comments

Comments
 (0)