Skip to content

Conversation

@mackdk
Copy link
Contributor

@mackdk mackdk commented Jun 25, 2025

What does this PR change?

When creating a virtual host manager, the list of provider is retrieved by calling virtual-host-gatherer --list-providers. This list however is also hard-coded in the typescript page for translation purposes. If a provided returned by virtual-host-gatherer is not present in the hard-coded list, currently the UI shows an empty entry in the Create button dropdown menu, making it impossible for the user to select it. This is currently happening for Libvirt, but it can happen for every new provider introduced in virtual-host-gatherer.

To address this, this PR ensure the provider is selectable even if it is not present in the hard-coded list and the UI is still fully functional.

GUI diff

Before:
image

After:
Note: Proxmox is a new provider part of currently open PR in virtual-host-gatherer (uyuni-project/virtual-host-gatherer#40)

image
image
image
image

  • DONE

Documentation

  • No documentation needed: bugfix on an already documented feature

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mackdk mackdk requested a review from Etheryte June 25, 2025 16:41
@mackdk mackdk requested a review from a team as a code owner June 25, 2025 16:41
@github-actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10509/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/10509/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@mackdk mackdk changed the title Ensure Virtual Host Manager page works when there is an unknown provider Ensure Virtual Host Manager page works with an unknown provider Jun 25, 2025
Copy link
Member

@Etheryte Etheryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@mackdk mackdk changed the base branch from master to master-staging July 25, 2025 13:45
@mackdk mackdk force-pushed the fix-vhm-provider-list branch from d8c2fc1 to 87f15ca Compare July 25, 2025 13:45
@mcalmer mcalmer requested review from a team as code owners July 26, 2025 14:33
@mcalmer mcalmer requested review from m-czernek and parlt91 and removed request for a team July 26, 2025 14:33
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testsuite changes LGTM.

@mackdk mackdk force-pushed the fix-vhm-provider-list branch from 87f15ca to 0ce9268 Compare July 28, 2025 08:53
@mackdk mackdk removed request for a team, m-czernek and parlt91 July 28, 2025 08:54
@mackdk mackdk merged commit 2f80651 into uyuni-project:master-staging Jul 28, 2025
42 of 43 checks passed
@mackdk mackdk deleted the fix-vhm-provider-list branch July 28, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants