-
Notifications
You must be signed in to change notification settings - Fork 222
Ensure Virtual Host Manager page works with an unknown provider #10509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Virtual Host Manager page works with an unknown provider #10509
Conversation
|
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10509/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Etheryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
d8c2fc1 to
87f15ca
Compare
srbarrios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testsuite changes LGTM.
87f15ca to
0ce9268
Compare
What does this PR change?
When creating a virtual host manager, the list of provider is retrieved by calling
virtual-host-gatherer --list-providers. This list however is also hard-coded in the typescript page for translation purposes. If a provided returned byvirtual-host-gathereris not present in the hard-coded list, currently the UI shows an empty entry in theCreatebutton dropdown menu, making it impossible for the user to select it. This is currently happening forLibvirt, but it can happen for every new provider introduced invirtual-host-gatherer.To address this, this PR ensure the provider is selectable even if it is not present in the hard-coded list and the UI is still fully functional.
GUI diff
Before:

After:
Note: Proxmox is a new provider part of currently open PR in
virtual-host-gatherer(uyuni-project/virtual-host-gatherer#40)Documentation
No documentation needed: bugfix on an already documented feature
DONE
Test coverage
No tests: already covered
DONE
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!