Skip to content

Conversation

@mackdk
Copy link
Contributor

@mackdk mackdk commented Apr 11, 2025

This PR improves mkchlog to add the following features:

  • Fixes how the feature name is generated when the branch name contains a /. Currently the resulting filename is invalid.
  • Removes any repeated and trailing whitespaces from the message typed on the command line. Currently, when wrapping the message into multiple lines a space might remain at the end, leading to a failure of the changelog test on the PR in uyuni.

I've also addressed multiple ShellCheck issues, improving the code quality.

@mackdk mackdk requested a review from a team as a code owner April 11, 2025 10:16
Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the improvements.

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we tag uyuni-releng-tools with tito and we use mkchlog for generating the changelog entries too.

Could you please add the changelog entries using mkchlog instead of editing the main .changes?

@mackdk mackdk force-pushed the improve-mkchlog branch from 7c317cd to 5c07efb Compare June 5, 2025 09:17
@mackdk mackdk requested a review from deneb-alpha June 5, 2025 09:18
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM!

@deneb-alpha deneb-alpha merged commit 9e1441b into main Jun 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants