Skip to content

Conversation

@meaksh
Copy link
Member

@meaksh meaksh commented Oct 7, 2025

What does this PR change?

This PR fixes two issues detected when deploying Uyuni released version:

  • Fix state to configure DB in uyuni-released
  • Fix some issues related to avahi (avahi-lang not existing in some cases - not really required for avahi functionality)
  • Fix issue propagating product_version when defined for single modules [0]

[0] if the product_version is not set at modules/xxxx/main.tf then it won't be available here: https://github.com/uyuni-project/sumaform/blob/master/backend_modules/libvirt/host/main.tf#L18 meaning, it will always fetch the product_version defined in "base", not allowing defining it for individual nodes.

@meaksh meaksh requested a review from a team as a code owner October 7, 2025 11:46
@nodeg nodeg requested a review from Copilot October 7, 2025 11:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses deployment issues for Uyuni released version by fixing database configuration state matching and resolving Avahi package dependencies. The changes ensure proper database configuration for all Uyuni versions and improve Avahi installation compatibility across different SUSE Linux Enterprise versions.

  • Simplified version matching logic for database configuration to include all Uyuni versions
  • Added support for additional SUSE Linux Enterprise versions (15.4, 15.5, 15.6) in Avahi repository configuration
  • Removed optional avahi-lang package dependency that may not exist in all environments

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
salt/server_containerized/large_deployment.sls Simplified version check to apply database configuration to all Uyuni versions
salt/default/avahi.sls Added repository URLs for SLE 15.4-15.6 and removed optional avahi-lang package

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@meaksh meaksh merged commit 7cf7346 into master Oct 8, 2025
2 checks passed
@meaksh meaksh deleted the master-fix-some-issues branch October 8, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants