more: pipe isn't working

[sylvestre]

Not sure it is used but:

$ cat foo.txt|more

is working with GNU.

Fails with our version:

$ cat foo.txt|./target/debug/coreutils more
more: incorrect usage

https://github.com/uutils/coreutils/blob/master/src/uu/more/src/more.rs
A test should be added in
https://github.com/uutils/coreutils/blob/master/tests/by-util/test_more.rs

[Arcterus]

I think this utility should be rewritten completely. It doesn't look like it'll be much effort, and there are now decent cross-platform terminal crates.

[sylvestre]

Probably, do you have one in mind?

[Arcterus]

I used crossterm recently and thought it was decent. It has some bugs here and there, but I doubt we'd encounter them with something like more.

[ycd]

Actually stdin-pipe works without termios with a very small change, but with termios it panics, it 'd be great if we rewrite this.

[Wabuo]

I'm keen giving it a shot(first proper rust project).

there are now decent cross-platform terminal crates

I guess that should be an uutils wide decision, how do we go about this? Shall I open an Issue?
What are the requirements we have? Things like:

• Supported platforms(Linux, Windows, BSD's, RedoxOS ..) architectures (i686, x86_64, RISC-V ..) [shouldn't that be a problem of the OS?]
• What dependencies will it pull in?
• code quality
• what happens if it gets abandoned, how easy can we move on or take it over?
• ...

Do we want more and less? Shall they use the same code base?

What did I miss?
Who got some input?

Cheers Wabuo

[tertsdiepraam]

Hi @Wabuo! Note that there is an open PR for a more rewrite which uses crossterm: #2109. If you want to work on more you might want to wait for that to get merged and work from there.

[Wabuo]

Oh well looks like I suck at using the search function, sorry.

Of I go, looking for another low-hanging fruit ...

[tertsdiepraam]

Fixed as a part of #2109