Defaults: memory_limit vs upload_max_filesize

[Leksat]

From https://docs.lagoon.sh/docker-images/php-fpm/#included-php-config

Value	Details
memory_limit = 400M	For big PHP projects (changeable via PHP_MEMORY_LIMIT).
upload_max_filesize = 2048M	For big file uploads.

But according to PHP docs

• memory_limit should be larger than post_max_size (link)
• post_max_size must be larger than upload_max_filesize (link).

So memory_limit > post_max_size > upload_max_filesize. Or at least they should be equal. But current defaults are different. So files more that 400M can't be uploaded.

[seanhamlin]

See https://stackoverflow.com/a/3651195/169882, the TLDR is that memory_limit does not need to be > post_max_size.

Checking a brand new site install on 23.06.0 images:

cli-drupal:/app$ php -i | grep -E 'upload_max_filesize|post_max_size'
post_max_size => 2048M => 2048M
upload_max_filesize => 2048M => 2048M

So post_max_size == upload_max_filesize @ 2 GB.

Pretty sure customers have uploaded large files through the web, and this is why the 2GB is in place by default.

[seanhamlin]

I just tried on a vanilla Drupal 10.1 on Lagoon, with a 560MB file, and indeed it does die

NOTICE: PHP message: PHP Fatal error:  Allowed memory size of 419430400 bytes exhausted (tried to allocate 536870944 bytes) in /app/web/core/lib/Drupal/Core/File/FileSystem.php on line 76

Perhaps Drupal needs PHP's memory to be inline with the max file to be uploaded? I wonder if this is due to the fancy AJAX that is part of the file upload screen (aka, this is not just a boring multi-part form POST)?

After bumping the PHP max memory to 800MB

It works.

So I think this is potentially a quirk of Drupal's AJAX handling that requires in memory processing of uploads. I wonder what a vanilla form with a PHP handler would do here?

Do you think Lagoon would be better to have post_max_size == upload_max_filesize == 400MB?

Potentially this discussion should be an issue I think?

[Leksat]

Do you think Lagoon would be better to have post_max_size == upload_max_filesize == 400MB?

At least there will be no confusion.

BTW, you could try disabling JS to see if it's caused by AJAX. Upload form should still work without JS.

[seanhamlin]

Looping in @tobybellwood

[steveworley]

Technically the memory limit doesn't impact the max upload; it's only because Drupal is trying to load the file into memory during the upload. PHP typically streams the file so it's not loaded fully into memory and would work this way. I suspect that your assertion of Drupal AJAX being the problem.

I think ideally they would be the same values to reduce ambiguity.

[Leksat]

I've found a Drupal core issue: https://www.drupal.org/project/drupal/issues/3366403