Skip to content

Commit 49d9730

Browse files
authored
require fake-useragent from pypi (#86)
* require fake-useragent from pypi Signed-off-by: vsoch <vsochat@users.noreply.github.com>
1 parent 73536c5 commit 49d9730

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,14 @@ jobs:
5151

5252
- name: Download ChromeDriver
5353
run: |
54-
wget https://chromedriver.storage.googleapis.com/103.0.5060.134/chromedriver_linux64.zip
54+
wget https://chromedriver.storage.googleapis.com/107.0.5304.18/chromedriver_linux64.zip
5555
unzip chromedriver_linux64.zip
5656
rm chromedriver_linux64.zip
5757
5858
- name: Test
5959
run: |
6060
export PATH="/usr/share/miniconda/bin:$PATH"
6161
source activate testing
62-
pip install git+https://github.com/danger89/fake-useragent.git
6362
pip install .[all]
6463
pip install -r tests/test-requirements.txt
6564
pytest -vs -x --cov=./urlchecker tests/test_*.py

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and **Merged pull requests**. Critical items to know are:
1212
Referenced versions in headers are tagged on Github, in parentheses are for pypi.
1313

1414
## [vxx](https://github.com/urlstechie/urlschecker-python/tree/master) (master)
15+
- switch back to pypi release of fake-useragent (0.0.34)
1516
- preparing to install from git for fake-useragent (0.0.33)
1617
- serial option for debugging (0.0.32)
1718
- adding support for web driver for harder URLs (0.0.31)

Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ RUN /bin/bash -c "source activate urlchecker && \
2424
which python && \
2525
which pip && \
2626
pip install --upgrade certifi && \
27-
pip install git+https://github.com/danger89/fake-useragent.git && \
2827
pip install .[all]"
2928
# Download chrome driver for selenium
3029
RUN /bin/bash -c "wget https://chromedriver.storage.googleapis.com/103.0.5060.134/chromedriver_linux64.zip && \

setup.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,7 @@ def get_reqs(lookup=None, key="INSTALL_REQUIRES"):
8686
long_description_content_type="text/markdown",
8787
keywords=KEYWORDS,
8888
setup_requires=["pytest-runner"],
89-
install_requires=INSTALL_REQUIRES
90-
+ [
91-
"fake-useragent @ git+https://github.com/danger89/fake-useragent@master#egg=fake-useragent"
92-
],
89+
install_requires=INSTALL_REQUIRES,
9390
tests_require=TESTS_REQUIRES,
9491
extras_require={
9592
"all": INSTALL_REQUIRES_ALL,

urlchecker/version.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88
"""
99

10-
__version__ = "0.0.33"
10+
__version__ = "0.0.34"
1111
AUTHOR = "Ayoub Malek, Vanessa Sochat"
1212
AUTHOR_EMAIL = "superkogito@gmail.com, vsochat@stanford.edu"
1313
NAME = "urlchecker"
@@ -23,7 +23,10 @@
2323
# Global requirements
2424

2525

26-
INSTALL_REQUIRES = (("requests", {"min_version": "2.18.4"}),)
26+
INSTALL_REQUIRES = (
27+
("requests", {"min_version": "2.18.4"}),
28+
("fake-useragent", {"min_version": "0.1.13"}),
29+
)
2730

2831
SELENIUM_REQUIRES = (("selenium", {"min_version": None}),)
2932

0 commit comments

Comments
 (0)