-
Notifications
You must be signed in to change notification settings - Fork 87
Description
The new Variable Markov Oracle algorithm (included in this PR) didn't pass the unit tests because of two reasons:
-
The results of the main vmo call did not follow the expected format:
len(my_bounds) == len(my_labels) + 1
. To fix this, I simply removed the last label (since it seemed that it was always repeated). @wangsix, could you confirm this is correct? -
When calling VMO to obtain the labels only (i.e., when we have used another algorithm to compute the boundaries), the previously computed boundaries were ignored. This was an MSAF problem, which I fixed by making sure we use the old boundaries in the interface. @WANGSIZ, do you think VMO could be improved by including previously computed boundaries to obtain the labels only? If not, the current labels synchronization to the previously computed boundaries should suffice.