Move stream to options

Author: zacksiri

lib/tama_ex/agentic.ex

@@ -7,7 +7,7 @@ defmodule TamaEx.Agentic do
       path = "/messages"
       timeout = Keyword.get(options, :timeout) || 300_000
       headers = Keyword.get(options, :headers) || []
-      stream? = Map.get(body, "stream") || Map.get(body, :stream)
+      stream? = Keyword.get(options, :stream)
 
       callback =
         if stream? do
@@ -32,7 +32,7 @@ defmodule TamaEx.Agentic do
         Req.merge(validated_client,
           method: :post,
           url: path,
-          json: %{message: message_params},
+          json: %{stream: stream?, message: message_params},
           receive_timeout: timeout,
           headers: headers
         )

lib/tama_ex/message/params.ex

@@ -12,8 +12,7 @@ defmodule TamaEx.Message.Params do
     :class,
     :identifier,
     :content,
-    :index,
-    :stream
+    :index
   ]
 
   @primary_key false
@@ -23,7 +22,6 @@ defmodule TamaEx.Message.Params do
     field :identifier, :string
     field :content, :string
     field :index, :integer
-    field :stream, :boolean, default: false
 
     embeds_one :author, Author
     embeds_one :thread, Thread

test/tama_ex/agentic_test.exs

@@ -206,10 +206,11 @@ defmodule TamaEx.AgenticTest do
           "identifier" => "thread-456"
         },
         "identifier" => "msg-stream",
-        "index" => 1,
-        "stream" => true
+        "index" => 1
       }
 
+      options = [stream: true]
+
       expected_message = """
       Stream handler is required when streaming is true pass a stream handler into options
 
@@ -223,7 +224,7 @@ defmodule TamaEx.AgenticTest do
       """
 
       assert_raise RuntimeError, expected_message, fn ->
-        Agentic.create_message(client, body)
+        Agentic.create_message(client, body, options)
       end
     end
 
@@ -234,7 +235,8 @@ defmodule TamaEx.AgenticTest do
         {:ok, body, conn} = Plug.Conn.read_body(conn)
         request_data = Jason.decode!(body)
 
-        assert request_data["message"]["stream"] == true
+        # Stream is now passed in options, not in the message body
+        assert is_map(request_data["message"])
 
         conn =
           conn
@@ -293,11 +295,10 @@ defmodule TamaEx.AgenticTest do
           "identifier" => "thread-456"
         },
         "identifier" => "msg-stream",
-        "index" => 1,
-        "stream" => true
+        "index" => 1
       }
 
-      options = [callback: callback]
+      options = [stream: true, callback: callback]
 
       response = Agentic.create_message(client, body, options)
 
@@ -342,7 +343,8 @@ defmodule TamaEx.AgenticTest do
         {:ok, body, conn} = Plug.Conn.read_body(conn)
         request_data = Jason.decode!(body)
 
-        assert request_data["message"]["stream"] == true
+        # Stream is now passed in options, not in the message body
+        assert is_map(request_data["message"])
 
         conn =
           conn
@@ -375,11 +377,10 @@ defmodule TamaEx.AgenticTest do
           identifier: "thread-atom"
         },
         identifier: "msg-atom",
-        index: 1,
-        stream: true
+        index: 1
       }
 
-      options = [callback: callback]
+      options = [stream: true, callback: callback]
 
       response = Agentic.create_message(client, body, options)
 
@@ -430,11 +431,10 @@ defmodule TamaEx.AgenticTest do
           "identifier" => "thread-mixed"
         },
         "identifier" => "msg-mixed",
-        "index" => 1,
-        "stream" => true
+        "index" => 1
       }
 
-      options = [callback: callback]
+      options = [stream: true, callback: callback]
 
       _response = Agentic.create_message(client, body, options)