Merge pull request #21 from uploadcare/chore/fix-test

chore: fix convertToUploadcareQualityString test

Author: nd0ut

.github/workflows/shipjs-manual-prepare.yml

@@ -1,13 +1,7 @@
 name: Ship js Manual Prepare
-on:
-  issue_comment:
-    types: [created]
+on: workflow_dispatch
 jobs:
   manual_prepare:
-    if: |
-      github.event_name == 'issue_comment' &&
-      (github.event.comment.author_association == 'member' || github.event.comment.author_association == 'owner') &&
-      startsWith(github.event.comment.body, '@shipjs prepare')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -16,49 +10,12 @@ jobs:
           ref: main
       - uses: actions/setup-node@v2
         with:
-          node-version: '14'
-      - run: |
-          if [ -f "yarn.lock" ]; then
-            yarn install
-          else
-            npm install
-          fi
+          node-version: '16'
+      - run: yarn install --frozen-lockfile
       - run: |
           git config --global user.email "github-actions[bot]@users.noreply.github.com"
           git config --global user.name "github-actions[bot]"
-      - run: npm run release -- --yes --no-browse
+      - run: yarn release --yes --no-browse
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SLACK_INCOMING_HOOK: ${{ secrets.SLACK_INCOMING_HOOK }}
-
-  create_done_comment:
-    if: success()
-    needs: manual_prepare
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/github-script@v3
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            github.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: "@${{github.actor}} `shipjs prepare` done"
-            })
-
-  create_fail_comment:
-    if: cancelled() || failure()
-    needs: manual_prepare
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/github-script@v3
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            github.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: "@${{github.actor}} `shipjs prepare` fail"
-            })

.github/workflows/shipjs-trigger.yml

@@ -15,14 +15,9 @@ jobs:
           ref: main
       - uses: actions/setup-node@v2
         with:
-          node-version: '14'
           registry-url: "https://registry.npmjs.org"
-      - run: |
-          if [ -f "yarn.lock" ]; then
-            yarn install
-          else
-            npm install
-          fi
+          node-version: '16'
+      - run: yarn install --frozen-lockfile
       - run: npx shipjs trigger
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test-and-lint.yml

@@ -9,23 +9,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-          ref: main
       - uses: actions/setup-node@v2
         with:
-          node-version: '14'
-      - run: |
-          if [ -f "yarn.lock" ]; then
-            yarn install
-          else
-            npm install
-          fi
-      - run: |
-          git config --global user.email "github-actions[bot]@users.noreply.github.com"
-          git config --global user.name "github-actions[bot]"
-      - run: yarn test
-      - run: yarn lint
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SLACK_INCOMING_HOOK: ${{ secrets.SLACK_INCOMING_HOOK }}
+          node-version: '16'
+      - name: Install dependencies
+        working-directory: ./
+        run: yarn install --frozen-lockfile
+      - name: Run tests
+        run: yarn test
+      - name: Run lint
+        run: yarn lint
+

src/__tests__/convert-to-uploadcare-quality-string.spec.ts

@@ -1,8 +1,8 @@
 import { convertToUploadcareQualityString } from '../utils/helpers';
 
 describe('convertToUploadcareQualityString', () => {
-  it('should map 0 to lightest', () => {
-    expect(convertToUploadcareQualityString(0)).toBe('lightest');
+  it('should map 1 to lightest', () => {
+    expect(convertToUploadcareQualityString(1)).toBe('lightest');
   });
 
   it('should map 38 to lightest', () => {
@@ -16,4 +16,9 @@ describe('convertToUploadcareQualityString', () => {
   it('should map 100 to best', () => {
     expect(convertToUploadcareQualityString(100)).toBe('best');
   });
+
+  it('should map falsy values to smart', () => {
+    expect(convertToUploadcareQualityString()).toBe('smart');
+    expect(convertToUploadcareQualityString(0)).toBe('smart');
+  });
 });

src/utils/helpers.ts

@@ -68,6 +68,8 @@ export function convertToUploadcareQualityString(
   requestedQuality?: number
 ): string {
   // If any particular quality has not been requested, we use the smart quality mode.
+  // zero quality is treated as no quality, so we use smart.
+  // see https://nextjs.org/docs/api-reference/next/image#quality
   if (!requestedQuality) {
     return 'smart';
   }