fix empty return of get_scope_data in case of long pre-simulation time

Author: gituser789

CHANGELOG.md

@@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.0.4] - 2024-07-01
+### Fixed
+- empty data return in get_scope_data() in case of a pre-simulation time longer than the steady-state simulation time
+
 ## [0.0.3] - 2024-06-26
 ### Added
 - 'set_nonlinear_file()' to set non-linear capacitance files
@@ -25,7 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 
 
-[unreleased]: https://github.com/upb-lea/pygeckocircuits2/compare/0.0.3...HEAD
+[unreleased]: https://github.com/upb-lea/pygeckocircuits2/compare/0.0.4...HEAD
+[0.0.4]: https://github.com/upb-lea/pygeckocircuits2/compare/0.0.3...0.0.4
 [0.0.3]: https://github.com/upb-lea/pygeckocircuits2/compare/0.0.2...0.0.3
 [0.0.2]: https://github.com/upb-lea/pygeckocircuits2/compare/0.0.1...0.0.2
 [0.0.1]: https://github.com/upb-lea/pygeckocircuits2/releases/tag/0.0.1

docs/source/conf.py

@@ -20,7 +20,7 @@
 project = 'PyGeckoCircuits2'
 copyright = '2024, UPB-LEA'
 author = 'UPB-LEA'
-release = '0.0.3'
+release = '0.0.4'
 # -- General configuration ---------------------------------------------------
 # https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration
 

pygeckocircuits2/geckoCircuitsRemote.py

@@ -553,7 +553,7 @@ def get_scope_data(self, node_names: Union[List, str], file_name: str, start_tim
 
         The data with respect to specified scope nodes are extracted and save to csv file locally.
 
-        :param node_names: the name provided to the scope nodes
+        :param node_names: the name provided to the scope nodes, e.g. ["v1", "i_l_1"]
         :type node_names: List[str] or str
         :param file_name: name of the csv file under which the extracted data needed to be exported
         :type file_name: str
@@ -568,7 +568,9 @@ def get_scope_data(self, node_names: Union[List, str], file_name: str, start_tim
         :rtype: None
         """
         stop_time = stop_time if stop_time and stop_time > 0 else self.ginst.get_Tend()
+        stop_time = stop_time + self.ginst.get_Tend_pre() - 2 * self.ginst.get_dt()
         start_time = start_time if start_time and start_time < stop_time else 0
+        start_time = start_time + self.ginst.get_Tend_pre()
         data = {}
         if isinstance(node_names, list):
             for node in node_names:
@@ -581,8 +583,11 @@ def get_scope_data(self, node_names: Union[List, str], file_name: str, start_tim
             df.insert(0, 'time', time)
             df.to_csv(path_or_buf=file_name+'.csv', encoding='utf-8', index=False, sep=' ', header=True)
         else:
+            df = None
             print('Nothing to be saved')
 
+        return df
+
     def get_values(self, nodes: Union[List, str], operations: Union[List, str],
                    range_start_stop: List[Union[float, str]] = None) -> Dict:
         """

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pygeckocircuits2"
-version = "0.0.3"
+version = "0.0.4"
 authors = [
     { name = "UPB-LEA" },
 ]