get_dealable_cards() is incorrectly listing mucked cards in certain cases (N>2 players in NL Texas Hold'em, + maybe other variants)

[Drazcmd]

E.g. say I have a 4 player NLHE game where one or two players have folded (and therefore mucked their hand). It appears that get_dealable_cards() will incorrectly include their cards as dealable when called.

The good news is:

• the bug is trivial to work around since .mucked_cards, .burn_cards, .board_cards, and .hole_cards are all getting updated correctly. Meaning as a workaround, users can trivially write a helper function that checks for this situation and then filters out the mucked cards
• I believe the internal checks here are all still working, i.e. before I had myself written+used such a helper function, pokerkit would correctly log a warning message any time I dealt one of these mucked cards

Note that:

• this definitely happens in no-limit Texas Hold'dem with 4 players
• I suspect it happens with other numbers of players > 2 and in the other game variants, but haven't had time to double check
• I don't have a good code sample demonstrating this on hand atm, but I believe it should be pretty trivial to replicate. (If not lmk here and I can go put one together)

[AussieSeaweed]

Hi, mucked cards (i.e., folded cards) are valid cards to be dealt if and only if there are not enough cards left in the deck. This happens quite frequently in draw games. I believe I implemented the get_dealable_cards method to only include the mucked cards if it sees that there are insufficient cards left in the deck.

[AussieSeaweed]

This image is from the documentation and kind of illustrates how PokerKit handles the cards.

[AussieSeaweed]

What is strange is that you see mucked cards being included in the dealable cards in Texas hold'em. That shouldn't happen, I think. I would appreciate, if you would come up with a small isolated example to demonstrate the bug.

[AussieSeaweed]

I remember now. I am pretty sure the issue is that you did not specify how many cards you want to deal (as an argument). When that happens, it will assume the worst-case scenario and include the mucked cards as dealable cards. Is this what you did? In that case I think it is worth adding a warning saying you probably want to specify how many cards you want to deal.