the isValidKey hook

[adeelhasan]

Just wondering how often is this hook used. it is called from within the balanceOf function, and can potentially be a very costly operation for Locks with many keys.

it depends on the context of usage -- which I am not so familiar with -- but it may make sense to:

• have a batch validity check
• have some sort of expiration on a check, so the contract assumes the hook does not need to be conferred in a certain time period
• run a separate loop if the hook is not set at the start; this avoids the repeated comparison cost embedded in the loop.

On the other hand, this may not be a problem in practice. I guess I should research the subgraph and see how many times hooks have been set.

The other related point I was wondering about was how a very large event could mint many ticket NFTs. has that ever come up in practice?