Skip to content

Attempt to improve function under-application and over-application errors #5665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Apr 25, 2025

Overview

WIP; don't review the code yet, still in experimental stages 🧑‍🔬

tester = do
  (each [1] +1 99 (288 + 99))

Before:
image

After:
image

Function under-application detection:

threeArgs :  Nat -> Int -> Text -> ()
threeArgs a b c = ()

tester : ()
tester =
  threeArgs 1

Before
image

After
image

Implementation notes

How does it accomplish it, in broad strokes? i.e. How does it change the Haskell codebase?

Interesting/controversial decisions

Include anything that you thought twice about, debated, chose arbitrarily, etc.
What could have been done differently, but wasn't? And why?

Test coverage

Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?

Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?

If you only tested by hand, because that's all that's practical to do for this change, mention that.

Loose ends

Link to related issues that address things you didn't get to. Stuff you encountered on the way and decided not to include in this PR.

@pchiusano
Copy link
Member

Wow, awesome!!!

@ChrisPenner ChrisPenner force-pushed the cp/function-errors branch from 0afcd23 to d35c9c5 Compare May 2, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants